This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Allow keyspace to be null #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NastasiaSaby
force-pushed
the
feature/keyspace-and-client-management
branch
from
5742ee6
to
037393b
Compare
Oliboy50
reviewed
Nov 14, 2016
| * @dataProvider unexpectedConfigValueDataProvider | ||
| */ | ||
| public function testUnexpectedValueConfig($configs) | ||
| { | ||
| $parameterBag = new ParameterBag(array('kernel.debug' => true)); | ||
| $container = new ContainerBuilder($parameterBag); | ||
|
|
||
| $this->if($extension = new TestedClass()) | ||
| ->exception(function() use($extension, $configs, $container) { | ||
| $this->if ($extension = new TestedClass()) |
There was a problem hiding this comment.
if () => it's weird to have a space between a methodName and its bracket
There was a problem hiding this comment.
[ ] => Brackets
( ) => Round brackets or parentheses
{ } => Curly brackets or braces
〈 〉=> Angle brackets or chevrons
bracket works for everything 
Oliboy50
reviewed
Nov 14, 2016
| @@ -236,16 +278,20 @@ public function testInvalidConfig() | |||
| $parameterBag = new ParameterBag(array('kernel.debug' => true)); | |||
| $container = new ContainerBuilder($parameterBag); | |||
|
|
|||
| $this->if($extension = new TestedClass()) | |||
| ->exception(function() use($extension, $configs, $container) { | |||
| $this->if ($extension = new TestedClass()) | |||
Oliboy50
approved these changes
Nov 14, 2016
gmillet
approved these changes
Nov 15, 2016
NastasiaSaby
force-pushed
the
feature/keyspace-and-client-management
branch
from
037393b
to
f4c1b66
Compare
lnahiro
approved these changes
Nov 15, 2016
gflament
reviewed
Nov 15, 2016
| @@ -213,13 +252,16 @@ public function testUnexpectedValueConfig($configs) | |||
| $container = new ContainerBuilder($parameterBag); | |||
|
|
|||
| $this->if($extension = new TestedClass()) | |||
| ->exception(function() use($extension, $configs, $container) { | |||
| ->exception(function () use ($extension, $configs, $container) { | |||
| $extension->load($configs, $container); | |||
| }) | |||
| ->isInstanceOf('\Symfony\Component\Config\Definition\Exception\InvalidConfigurationException'); | |||
|
|
|||
gflament
approved these changes
Nov 15, 2016
NastasiaSaby
force-pushed
the
feature/keyspace-and-client-management
branch
from
f4c1b66
to
c95374c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation between client configuration and connection configuration (with keyspaces defined).
We do not have to define a keyspace for a new client.