Symfony5 support #36
Merged
Symfony5 support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Oliboy50
approved these changes
Feb 26, 2020
|
@Oliboy50 What are the next steps? Is there someone else who should take a look? How far are we to create a new tag? Thanks a lot! |
pabedu
approved these changes
Feb 27, 2020
|
@Adrians-G our CI seems to run tests against the symfony 4.4 dependencies would it be possible to make it run also tests against symfony 5+? |
omansour
suggested changes
Feb 27, 2020
Oliboy50
reviewed
Feb 27, 2020
maximebilliau
approved these changes
Feb 27, 2020
Co-Authored-By: Oliver THEBAULT <Oliboy50@users.noreply.github.com>
Co-Authored-By: Oliver THEBAULT <Oliboy50@users.noreply.github.com>
Co-Authored-By: Oliver THEBAULT <Oliboy50@users.noreply.github.com>
Oliboy50
reviewed
Mar 2, 2020
Co-Authored-By: Oliver THEBAULT <Oliboy50@users.noreply.github.com>
|
CI seems to be passing now. Please take a look for further suggestions. |
omansour
approved these changes
Mar 10, 2020
|
Thanks for your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are green and it seems to be working fine locally.
What could be other things we need to check?