feat(header): Allow to add specific Host header #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For optimization purpose, we intend to use a proxy between Php and ES in order to maintain persistent http connections opened. To do this in a common way, the http request must be addressed to the proxy, but using an
Host
header indicating the actual ES server to reach.Unfortunately,
Host
header is not handled correctly, since the ES client already split the input url into scheme, uri… and ahost
header. Then, when we try to add our ownhost
header, previous one is dropped 😕The final url is computed in the
CurlFactory
of guzzle/RingPhp (deprecatde), usingCore::url
function, but if anurl
field already exist, the client use it.The idea here is to compute the final url before to modify headers, in order to keep original host in the url.
Since
url
field is always computed, tests must be updated to take this new parameter into account.