This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Fix react/react version for compatibility #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonjour Je pense qu'il y a une dépendance cassée avec reactphp Je ne sais pas si je m'exprime bien mais si l'on compare la version 0.4.4 de reactphp et la version 0.4.1 0.4.4 : https://github.com/reactphp/http/blob/v0.4.4/src/Server.php#L68 0.4.1 : https://github.com/reactphp/http/blob/v0.4.1/src/Server.php#L61 Le emit('data' sur la request est envoyé seulement lorsque le boddy buffer est non vide (et donc pas tout le temps, pas lors d'une simple requete GET) Hors dans https://github.com/M6Web/PhpProcessManagerBundle/blob/master/Bridge/HttpKernel.php#L48 Le parti est pris que l'on a systématiquement cet evenement Donc cela ne marche plus Si dans votre composer.json on fixe un dependance vers reactphp/react non pas à "react/react" : "^0.4" Mais à "react/react" : "0.4.1" Il ne devrait plus y avoir de soucis. Merci pour votre temps Please, make my application superflight again !
Oliboy50
reviewed
Nov 13, 2017
| @@ -14,7 +14,7 @@ | |||
| "require": { | |||
| "php": "^5.5|^7.0", | |||
| "symfony/symfony" : "^2.7|^3.0", | |||
| "react/react" : "^0.4" | |||
| "react/react" : "0.4.1" | |||
There was a problem hiding this comment.
you could even fix it to 0.4.3
=> https://github.com/reactphp/http/blob/v0.4.3/src/Server.php#L61
|
damn, tests are also failing :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour
Je pense qu'il y a une dépendance cassée avec reactphp
Je ne sais pas si je m'exprime bien mais si l'on compare la version 0.4.4 de reactphp et la version 0.4.1
0.4.4 :
https://github.com/reactphp/http/blob/v0.4.4/src/Server.php#L68
0.4.1 :
https://github.com/reactphp/http/blob/v0.4.1/src/Server.php#L61
Le emit('data' sur la request est envoyé seulement lorsque le boddy buffer est non vide (et donc pas tout le temps, pas lors d'une simple requete GET)
Hors dans
https://github.com/M6Web/PhpProcessManagerBundle/blob/master/Bridge/HttpKernel.php#L48
Le parti est pris que l'on a systématiquement cet evenement
Donc cela ne marche plus
Si dans votre composer.json on fixe un dependance vers reactphp/react non pas à
Mais à
Il ne devrait plus y avoir de soucis.
Merci pour votre temps
Please, make my application superflight again !