-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to define sub-settings by module #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is OK for me. However the concept of "project" sounds strange for me. The project is the place where you want to use bemlinter. We want to apply different configs on project subsections. It's maybe "modules" rather than "projects", WYT ? It's just a naming observation 😺
sources: [`${__dirname}/sources/mixed-settings/project-prefixed.scss`], | ||
classPrefix: 'c-', | ||
filePattern: 'project-([^.]*)\.scss' | ||
}] | ||
})); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it seems there is no .editorconfig
file in the project to tell your IDE to auto-add an empty line at the end of each file 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Done!
@fdubost 👍 The |
✅ Rename option to |
There was a problem on how bemlinter linted multi-settings on single-website project:
So I change the bemlinter behaviour to allow settings override in a specific module.
What changed:
options
, to get the linter options for a specific file path{moduleName, blockName}
Usage example: There is a style leak (a block styling another block) and we want to mark the external block as errored
Extra:
😞 Sorry for the fat PR, it is a big change for the bemlinter. There is certainly some improvment to do on the code readability...