fix(array): fix set() with a path going through an array #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use
set()
with a path that contain an array, the array reconstruction can miss some elements.For example, considering having this base object:
If we want to update the path
a.b.0.next
there was no problem, but if we update the patha.b.1.next
we lost the thrid and forth elements.This happens when rebuilding the array. Here is an extract of the library code:
In our case,
key + 1
is evaluted to11
since key was a string. So we lost the values from 2 to 10.My PR add the described test, and a
parseInt()
to avoid this problem.