Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config php70 #1

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Add config php70 #1

merged 1 commit into from
Jul 5, 2017

Conversation

jb-reynaud
Copy link
Contributor

Why

Add a new config for project on php7.0.

How

Copy from php7.1.

@jb-reynaud jb-reynaud merged commit cde7e33 into master Jul 5, 2017
@jb-reynaud jb-reynaud deleted the feature/add-config-php70 branch July 5, 2017 09:55
lucascourot
lucascourot reviewed Jul 17, 2017
View reviewed changes
Copy link
Contributor

@lucascourot lucascourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The PHP7.1 profile was meant to be backward compatible. As the rules for both PHP 7.1 and PHP < 7.1 look the same in your PR, I don't see the point to have duplicated the profile. We won't do this for each version of PHP we use, will we?

@jb-reynaud jb-reynaud mentioned this pull request Jul 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascourot lucascourot lucascourot left review comments

@valentin-claras valentin-claras valentin-claras approved these changes

@b-viguier b-viguier b-viguier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jb-reynaud @lucascourot @valentin-claras @b-viguier