update fos/php-cs-fixer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliboy50
approved these changes
Jan 5, 2018
lucascourot
suggested changes
Jan 5, 2018
composer.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "friendsofphp/php-cs-fixer": "~2.8.0" | |||
| "friendsofphp/php-cs-fixer": "~2.9" | |||
There was a problem hiding this comment.
We had some breaking changes with php-cs-fixer v2 previously (https://github.com/M6Web/php-cs-fixer-config/pull/8/files), that's why we decided to remove the composer semver notation and stick to 2.8 only as php-cs-fixer didn't seem to be semver ready.
We should ensure that upgrading to 2.9 doesn't break anything on our internal repositories before doing that. In all cases we should better stick to ~2.9.0 instead of ~2.9.
lucascourot
approved these changes
Jan 8, 2018
DocRoms
force-pushed
the
feature/update-php-cs-fixer
branch
from
863a740
to
810b6b4
Compare
Stax
approved these changes
Jul 12, 2018
Fix minor number of php-cs-fixer version Update cs-fixer Fix composer fixer minor version Fix Version
DocRoms
force-pushed
the
feature/update-php-cs-fixer
branch
from
810b6b4
to
c9ba6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fos/php-cs-fixer
2.8.0to2.12.2in composer.json