fix: remove braces rule #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bchaises
force-pushed
the
fix/remove_braces_rule
branch
from
6f93df5
to
d2f8207
Compare
fferriere
approved these changes
Jun 6, 2023
emyrtille
approved these changes
Jun 6, 2023
Oliboy50
approved these changes
Jun 6, 2023
Bchaises
force-pushed
the
fix/remove_braces_rule
branch
from
d2f8207
to
1bb6063
Compare
Oliboy50
approved these changes
Jun 8, 2023
emyrtille
approved these changes
Jun 12, 2023
Fabex
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The
bracesrule has been deprecated since version 3.16 of PHP-CS-Fixer so it must be removed and replaced by its equivalents.However, those rules ("single_space_around_construct", "control_structure_braces", "curly_braces_position", "control_structure_continuation_position", "declare_parentheses", "statement_indentation", "no_multiple_statements_per_line" and "no_extra_blank_lines") are already enabled in PHP-CS-Fixer.
In addition, the
friendsofphp/php-cs-fixerversion must be changed to 3.16 minimum, since one of the rules,single_space_around_constructbecomes usable from this version.