Removed hasTag function due to Error in Symfony 4.3.*

[DevNico]

When using Symfony 4.3.* the "hasTag" function causes the Error: Property "tag" does not exist in class "App\Entity\SomeEntity". Therefore I propose removing it.

This is my first PR so any feedback regarding my description or anything else would be greatly appreciated!

[garak]

I appreciate your effort.
But, before opening a PR, you should open an issue describing the supposed error. Maybe there's a simpler solution, not involving the change of an interface (that's a BC break)

[DevNico]

Okay noted for next time. Do you have any idea on how to solve this without changing the interface?

[garak]

You should provide a way to reproduce your error

[DevNico]

Php Version: 7.3.6 via homebrew on macOS Mojave 10.14.5

Steps to reproduce:

• composer create-project symfony/website-skeleton my-project && cd my-project
• composer require symfony/orm-pack
• composer require --dev symfony/maker-bundle
• composer require symfony/form
• composer require beelab/tag-bundle
• php bin/console make:entity (Create a test entity)
• Make it extend AbstractTaggable and add fields as shown in the documentation
• php bin/console make:crud (For the test entity)
• symfony serve (Go to: https://localhost:8000/test/entity/new, or what ever the link to your entity create page is)
  => First error: $tags needs to be protected instead of private (Docs error)
  => Second error after changing to protected: Property "tag" does not exist in class "App\Entity\TestEntity"

Example repository: https://github.com/DevNico/Tagbundle-Error-Demo

[garak]

Well done (except for missing .env in repo).
So, you're trying to use a form bound to an entity, but unfortunately the fields you defined in form don't match properties in your entity.
I suggest you to re-read (I'm sure you already read it once) documentation about Symfony forms

[DevNico]

I'm sorry but I don't think that's the case. In the TestEntityType buildForm function the only fields I add are: name, updated and tagsText. Those all exist and match my entity! I think the problem still is that Symfony sees the HasTag Method and then proceeds to look for a tag property - why? I don't know. If I didn't get something could you please clarify again?

[garak]

I see you changed your form.
Still, fields in your form don't match properties in your entity

[DevNico]

I'm sorry but I don't get what you mean by that. Could you elaborate that a bit more?

[garak]

Try this:

• fix class reference in src/Form/TestEntityType.php
• remove updated field in src/Form/TestEntityType.php
• comment out last 2 lines in config/packages/validator.yaml and provide your own validation

[DevNico]

Thanks a lot! I got it to work. Next time I will just write an issue. The only thing you might want to change is the part of the documentation where $tags is private to protected!