Basemats Part 1: Framework & Fixes

[Tsar-Salat]

Ports:

• Material datum chairs & tables and applies materials to all items (Now with less pain for mining & RnD) tgstation/tgstation#46525 (Expands basemats to constructable materials besides coins. Fixes old basemats issues from 4 years ago)
• Fixes mat irradation / exploding tgstation/tgstation#46994 (constructing things wont inherit basemats properties)
• Fixes some material datum bugs tgstation/tgstation#47049 (see above)
• Fixes a bug that allowed the multiplication of materials. tgstation/tgstation#48584
• Fixes integrity issues related to datum mats tgstation/tgstation#48586 (Glass doesnt break from a single punch.)
• Makes the global materials lookup lazily initialized tgstation/tgstation#49173 (Quicker and easier)
• reduce amount of lists that exist during runtime for custom materials tgstation/tgstation#50832
• Nerfs uranium material effects, and changes how effective materials are on sheets and statues tgstation/tgstation#54178 (Uranium became very obnoxious & could irradiate the whole station)
• Fixes a few bugs with greyscale stacks. tgstation/tgstation#54858 (Stacks werent stacking or being placed in world properly)
• Wooden tables now obey The Law of Conservation of Mass tgstation/tgstation#56156
• Replaces MATERIAL_NO_EFFECTS with MATERIAL_EFFECTS. tgstation/tgstation#61166

About The Pull Request

This PR is an attempt at porting basemats, while trying to skip all the problems it caused at the time of its initial implementation. (Looking at you Uranium coins.)

DISCLAIMER: While the port list is long, this is effectively ONE content pr, with NINE fix prs stacked on top. This is very much a framework, as I did not wish to knowingly introduce the horrendous bugs the single pr brought upon TG. As such I've limited the applicable basemat materials quite a bit, all expansions to this are planned in Part 2

Effectively, basemats are a concept of making chairs and other objects from different materials, and the crafted objects from those materials inheriting their properties

closes #10245

TODO

• All basemat tables constructable
• All basemat chairs constructable
• Deconstructing basemat structures gives back the material investment
• up-to-date table sprite
• Miner satchel protects against radiation from uranium ore
• Stacks merge correctly. Exact Material values when converting from tile --> material --> chair

Why It's Good For The Game

We technically already have it, just at a small scale. I think adding the framework to this will mesh with Pigeons planned ideas nicely.

Players also have been wanting things like statue sculpting & tile reskinning, of which this is a prerequisite.

Testing Photographs and Procedure

Screenshots&Videos

Searers are made with plasma as an ingredient, but added code in protolathe makes sure they dont inherit plasma's burn-on-hit ability

Deconstructing the objects gives back the expected materials

decon.mp4

Tables & Chairs

Testing Stacks and Material refunding

dreamseeker_I0nd6L2ATM.mp4

Changelog

🆑 rkz, kitz-katz, willox, ninjanomnom, haukeschaumann, Qustinnus, TemporalOroborous
add: Adds additional framework to basemats, Materials under the label 'basemat' include Iron, Titanium, Plastic, Uranium, Plasma, Silver and Gold.
add: Adds ability to craft chairs and tables out of any basemat material.
tweak: Miner satchels now provide minor radiation protection from their contents, this is to prevent uranium ore from giving you cancer just for existing.
refactor: lazy initializes the basemats subsystem to cut down on processing
refactor: reduces overall unecessary lists in the basemats & custom_materials code
fix: fixes a bug relating to duplicating materials
fix: fixes a bug where basemats would exagerrate their material properties.
fix: fixes a bug where basemats properties would be inherited by anything crafted with them in an auto/protolathe
/:cl:

[Tsar-Salat]

Gonna be broken as shit for the time being, just a proof of concept for now.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

Im going to simply not include glass & diamond. Theres already quite some heft to this PR, we can find a snowflake solution to that later.

A maintainer also told me they didnt like Diamonds being a basemat, so that will be an opportunity to make it more palatable.

[Tsar-Salat]

This PR is now good to go

[PowerfulBacon]

Risky merge

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

I lied. That modular fabricator code was gross.

Explicitly defining what we want to inherit material effects should generate a hell of a lot less edge-cases & use less processing.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[itsmeow]

yolomerge 2 electric boogaloo

[Rukofamicom]

This PR made an unnecessary variable name change across the board. This causes unnecessary conflicts and headaches for open PRs for no substantial gain.

materials did not need to be renamed to custom_materials. If there was a variable name conflict, the new variable being introduced should be adjusted.

[EvilDragonfiend]

I am personally not against var name change when a massive change like this was brought because it is a good notification for people who are doing some works on the changed variable.