New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023's viro rework: removing viro #10153
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
not, of course, ready for review |
31ea18d
to
a6666f2
Compare
I've finished everything but the cure revamp, which is not as important. I have not tested anything yet, however. Should also port @Absolucy 's changes to necrotic adaptation to this. |
just added a buncha .stat checks for necrotic metabolism. shouldn't proc to_chats now. A few symptoms totally have it disabled, especially problematic instances. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
55fd132
to
58b1516
Compare
11b7cf3
to
ed45da5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testmerge passed. I see nothing particularly wrong.
The issue here is that the code has a lot of config options to make it hardly readible, but I guess it's a fair cost since we decided to keep it configurable with our complex feeling we have - we hate them and we love them.
Do not merge until Crossed approves the configuration. |
These are only basic config additions and has no chance to change anything on the hosting/server side, crossed doesn't really need to ensure their correctness |
* it begins * it begins * change * commit * more work done * --- * puts event check in * changes for necrotic metabolism * fixes and desca * enables neutering * disables normal zombie outbreaks * removes previous change * removes owo_talk from toxoplasmosis sapiens * config * fixes disease id sorting for view
About The Pull Request
This pull request is focused on removing virology as a job in a non-destructive manner, and changing virology mechanics to reflect its removal
CONFIG CHANGES
the following changes can be toggled on or off in config, for friendliness to downstreams
-For mappers, virology needs: a virology mapping helper over each access airlock(maints included), which should be labelled PHARMACY or somesuch, a mapping helper over a smoke machine, a mapping helper over a potted plant, and a l3closet/virology/starter. There still needs to be a preloaded viro smartfridge, a monkey enclosure, and a pandemic machine, but the area should be freely accessible to all medical personell.
--option to change whether necrotic metabolism causes diseases to process while in corpses
the following changes exist to make the customizability of viruses heavily tunable. currently, they're somewhat customizeable (currently, with enabled options, you can combine viruses and remove some symptoms, and neuter others. heavily rng dependent based on what viruses spawn and what symptoms can be removed (symptom removal uses rng fixed at roundstart), making spreadsheet viro nearly impossible most rounds.)
-option to limit how many symptoms can be removed from a virus. At this time, I have synaptizine no longer function on viruses with four or less symptoms
-option to make symptom removal "Seeded"- every round, symptom IDS are scrambled, and the lowest ID symptoms are always removed from a virus first. this makes rng-based isolation with tenacity impossible. this is now enabled
the following changes exist to make random viruses more impactful, and make virology a bit easier to compensate for a lack of fine-tunability.
Non- config changes
-change how extrapolators are obtained. now, they're obtained through science
Why It's Good For The Game
virology as it is is extremely bad for roleplay. The virology department is poorly equipped to deal with actual outbreaks, and spreading beneficial diseases adds little positive to the game. This means the department is either powergame fuel for people who spend hours making out of game spreadsheets, or grief fuel and banbait. often both.
this style of removal still leaves enough disease customization in to engage players who wish to engage with it, but does not reward a hefty array of spreadsheets and recipes, instead encouraging a more intuitive grasp of the system and how symptoms mesh together
Whether or not I make this PR, viro will be removed, so I'd prefer to be the one to kill it. with this approach, downstreams will still be able to enjoy beeviro, without worrying about upstream nerfs or removals disturbing it
Testing Photographs and Procedure
-draft-
Changelog
🆑
del: removes the virologist role. this is config based.
del: Removes most means to customize viruses This is config based. Currently, you can remove up to 2 symptoms from a disease, neuter symptoms, and mix viruses. Symptom removal is not random, with each symptom being removed based on a value given at roundstart.
del: dermagraphic ovulogenesis symptom
tweak: while virus customization is disabled, virus sample crates instead ship 5 isolated utility symptoms
add: re-adds viro zombies. They're now weaker, and only spread their diseases, instead of spreading the tumor itself.
add: adds a new chemical reaction, which allows you to remove faltered, immutable, dormant, and carrier status from viruses
balance: random viruses made through events should be more impactful now
balance: some symptom thresholds should be far easier to reach. config controlled.
mapping: adds tools for mappers to make virology departments a pharmaceutical research lab accessible by all medical personelll unless viro is enabled
tweak: toxoplasmosis sapiens is now level 0, and can technically appear, but, like all level 0 symptoms, will practically never appear, and will be even less likely to have any significant effect. However, the owo speak effect has been substantially toned down, and should now only impede the speech of certain letters and induce random cat noises, rather than replacing words arbitrarily.
/:cl: