Heretic touhou minigame no longer leaves bluespace wakes #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
approved these changes
Dec 16, 2023
|
Largely unrelated to this PR, but I'm willing to bet there's probably quite a few other things that leave wakes that shouldn't. |
|
In theory, the area should be set to NO_TELEPORT so that you can't teleport there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The heretic touhou minigame teleport no longer leaves behind bluespace wakes, meaning you can't hand tele into the shadow realm and promptly get stuck there with no way out besides admin intervention.
Also, changes the return teleportation to use the "free" channel, to reduce the chances of any weird edge cases resulting in someone possibly getting stuck or something.
Why It's Good For The Game
Because this is likely unintended behavior, and it leads to a softlock.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
馃啈
fix: You can no longer use a hand tele to enter and promptly trap yourself in the heretic touhou shadow realm.
/:cl: