Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up turnstile code and fixes it properly. #10494

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Haliris
Copy link
Contributor

@Haliris Haliris commented Jan 16, 2024

About The Pull Request

Fixes turnstile not checking for access properly. Simplified the code and axed a lot of overhead for the sake of sanity.

Why It's Good For The Game

Fixes broken interaction, now the turnstile work properly.

Testing Photographs and Procedure

Screenshots&Videos

image
Peasants get denied access now

Changelog

馃啈 Powerfulbacon, Haliris
fix: Fixed turnstile not checking for access proper
code: Cleaned up turnstile code
/:cl:

Turnstiles now work properly again.

Simplified the code and axed a lot of potential interactions for the sake of sanity.

Co-Authored-By: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
@Miliviu
Copy link
Contributor

Miliviu commented Jan 16, 2024

I guess it closes #10487

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical hotfix for the turnstiles allowing anyone to just walk out of prison

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jan 16, 2024
Merged via the queue into BeeStation:master with commit 0956ae4 Jan 16, 2024
8 checks passed
@Haliris Haliris deleted the genpop-turnstile-fix branch January 17, 2024 01:33
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Turnstiles now work properly again.

Simplified the code and axed a lot of potential interactions for the sake of sanity.

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants