Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerfs fugu gland somewhat #10554

Closed
wants to merge 2 commits into from

Conversation

Rukofamicom
Copy link
Contributor

@Rukofamicom Rukofamicom commented Jan 28, 2024

About The Pull Request

  • Reduces damage buff of fugu gland by 50% (It now boosts damage by 50% instead of doubling it)
  • Removes the immediate destruction flags from fugu gland buff, so mobs cannot bypass destruction checks with fugu gland
  • Checks if object damage is lower than combat damage and sets it to match if it is. This means certain mobs that already have boosted object damage will see less of a buff to their object damage from fugu gland, or potentially no buff at all. For mobs which do not have

Why It's Good For The Game

Fugu glands were overlooked when environmental damage was updated. Mobs do not need the ability to instantly destroy reinforced walls in a single click.

Testing Photographs and Procedure

There is no testing evidence at this time, it will be provided upon request if necessary - The PR changes are minimal and I do not believe testing is necessary in this case.

Changelog

馃啈
balance: Fugu gland now increases the damage output of the mob it is applied to by 50% instead of 100%
balance: Fugu gland no longer bypasses environmental damage checks for mobs it is applied to. The gland will still increase object damage to equal the newly buffed combat damage if it is higher.

/:cl:

Removes environment smash flags
Reduces damage buff by 50%
A.transform *= 2
A.environment_smash |= ENVIRONMENT_SMASH_STRUCTURES | ENVIRONMENT_SMASH_RWALLS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just an AI flag which lets them know they are capable of breaking walls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright yeah, this entire PR was born of me being lied to and mis-interpreting the code afterwards.
Not anything wrong with fugu glands, though I do still think the 100% boost in damage is a bit steep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants