/datum/map_adjustment for map change, job change for each station
#11210
+105
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
commented
Jul 18, 2024
XeonMations
reviewed
Jul 18, 2024
|
station now can be the centre of the universe |
There was a problem hiding this comment.
Why does radstation have no lavaland?
There was a problem hiding this comment.
rad and echo stations have ores to mine from itselves. That's it. but it won't be that necessary. I am honestly not sure if it would make any meaningful change.
There was a problem hiding this comment.
ahhhhhhhh, it was glow station, not rad station lmao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
/datum/map_adjustmentfor map change, job change for each stationmap change code is miserable, also our code isn't really good to make a detailed adjustment for each station
this system can adjust station details like job slot, job access, having-lavaland-or-not, and so on.
NOTE
ideally, moving json features to this datum would be nice, but I am not interested to make a lot of change right now.
Why It's Good For The Game
each station needs a different set up, and this datum supports it.
Testing Photographs and Procedure
Station is orbitting Phobos, and we have no lavaland
job change works well
Changelog
🆑
code: /datum/map_adjustment is newly added - used to adjust map details.
tweak: Echo station no longer spawns Lavaland, and it will be the centre of the universe instead of Lavaland planet
/:cl: