Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

another viro rebalance [resistance spec nerf, spiked skin nerf, memes, changes] #2198

Merged
merged 12 commits into from Aug 12, 2020

Conversation

zeskorion
Copy link
Contributor

@zeskorion zeskorion commented Jul 25, 2020

About The Pull Request

-Pituitary Disruption: at res 12, now tries to implant teratoma organs into you, and regrows limbs, including the head. The first part is really not an upside... Teratomas are also rarer
-autophageocytosis: no longer damages undead mobs, now turns infectious zombies into fast zombies, with no slowdown and no armor.
-spiked skin armor is now capped at 35, instead of 60
-if you change into a species with a biotype unable to support your disease, you lose the disease.
-species that dont breath will no longer die of ARDS making them unable to breath
-nanites symptoms can fuck with your nanites. Silicolysis will make them go haywire, and nano-symbiosis will make them activate willy-nilly
-necroseed: tendril spawn rate halved, more restrictions are placed on necrochests, and it no longer fucks you up for curing it
-regen coma: stealth threshold now procs all symptom's ondeath(). This is neutral in terms of nerfing and buffing
-blob spores: higher chance to spawn blobbernauts, equal to resistance
-beesease: level and severity lowered by one
-pierrot's throat: honkspread range and probability buffed
-many symptoms: stat changes across the board, trying to make some lesser-used symptoms a bit more handy.

Why It's Good For The Game

because i think all of the above is. resistance viruses are the best option ATM, and i wanna start changing that.

Changelog

馃啈 Zeskorion, LilithRofocale
add: pituitary disruption is now more fun
add: fast zombies
imageadd: fast zombie sprites from LilithRofocale
tweak: autophageocytosis no longer kills its own zombies or undead mobs
tweak: shit-tier disease cure changed from sugar to water, so beesease wont cure speed specced diseases
balance: spiked skin armor cap lowered by 25
balance: nanite symptoms now screw with nanites.
balance: necroseed made less annoying and memeable
balance: stat changes to disease symptoms across the board
fix: you can no longer die of acute respiratory distress if you don't need to breath
fix: should fix a few issues with onadd() and refresh() not being called when they should
fix: pituitary disruption size fuckery should now work properly. Instead of using a calculation, it makes you do a single waddle, preventing the symptom from being gamed using clown shoes to become a midget
fix: dna saboteur severity should now work properly
fix: changing species now cures viruses you cannot have as the new species
fix: fixes necrotizing fasciitis and autophageocytosis having switched severity values
fix: Blob spores no longer deletes the disease it comes in when it procs (it called qdel(), for god's sakes, not even using cure())
fix: fixes diseases runtiming when they are cured and activate in the same tick
/:cl:

@zeskorion
Copy link
Contributor Author

DNM pending icons

@imw-Oculus
Copy link

imw-Oculus commented Jul 26, 2020

Does this bug-fix this issue with spiked skin?
I'll review the particular balance things, and post again. Considering the limited positive implementations that are available for Virology, I'm hesitant.

@zeskorion
Copy link
Contributor Author

Does this bug-fix this issue with spiked skin?
I'll review the particular balance things, and post again. Considering the limited positive implementations that are available for Virology, I'm hesitant.

issues already fixed in a previous pr. I've always taken baby steps with buffing beneficial shit, and i think beneficials are in a good place right now, provided your goal isn't to spread them, which i've further nerfed here

@imw-Oculus
Copy link

Oh, then why hasn't that issue been closed? Gah!
Anyway, yeah - like I said, I'll take a peek at the balances, and bitch and whine - or give you a big hug, accordingly.

@imw-Oculus
Copy link

imw-Oculus commented Jul 26, 2020

Well. Huh. I was really worried about fiddling with such an intricate system - but all these seem fine. My only gripe would be reducing Stealth with Fever, as much as that makes sense. There are a very limited number of ways to pass the Stealth threshold. You've still earned a hug, though. All of these seem logical, and I especially appreciate how you streamlined the size-change symptom. Elegant bit of coding, that.
EDIT: Oh, and one more thing - the Nanite symptoms. I'd argue that the number of times both Nanites and Virology are used in conjunction is so small, that nerfing them to have a chance of failure - which is virtually guaranteed by the frequency of symptom triggering - is bad. What would be the point of having those symptoms, especially the one that buffs Nanite generation rates, if there is a guarantee of eventual catastrophic failure? If would relegate a rarely used symptom into a symptom that is never used.

@zeskorion
Copy link
Contributor Author

Well. Huh. I was really worried about fiddling with such an intricate system - but all these seem fine. My only gripe would be reducing Stealth with Fever, as much as that makes sense. There are a very limited number of ways to pass the Stealth threshold. You've still earned a hug, though. All of these seem logical, and I especially appreciate how you streamlined the size-change symptom. Elegant bit of coding, that.
EDIT: Oh, and one more thing - the Nanite symptoms. I'd argue that the number of times both Nanites and Virology are used in conjunction is so small, that nerfing them to have a chance of failure - which is virtually guaranteed by the frequency of symptom triggering - is bad. What would be the point of having those symptoms, especially the one that buffs Nanite generation rates, if there is a guarantee of eventual catastrophic failure? If would relegate a rarely used symptom into a symptom that is never used.

fever is one of the best stat symptoms. I did that change with the express purpose of getting people to use other symptoms instead, like the ones i buffed

Nanite generation is one of the best symptoms due to how powerful nanites are, and as of now it only slightly fucks with nanites- turning them on and off again, basically. Silicolysis is the one that fucks shit up.

@ghost
Copy link

ghost commented Jul 28, 2020

Please add diarrhea and radioactive resistance to one of the possible virus symptoms.

@zeskorion
Copy link
Contributor Author

Please add diarrhea and radioactive resistance to one of the possible virus symptoms.

code it yourself

@imw-Oculus
Copy link

Again, I really think you're underestimating how huge an impact messing with Nanites in the way that you've coded has. Nanite programming generally relies on precision, and removing that precision removes any reason to use the Nanite symptoms.
I have yet to see a single instance of a Scientist working with Nanites combine their efforts with a Virologist. I'm sure it happens on rare occasion, but certainly not often enough to warrant the nerfs you've prescribed. If I were to work with Nanites, why would I ever want to introduce a chance of critical failure to them?
Also:
"fever is one of the best stat symptoms. I did that change with the express purpose of getting people to use other symptoms instead, like the ones i buffed"
Removing utility and functionality from things will always attract my ire.
I really wouldn't want to see this PR merged, frankly. You bundle so many different changes in - some good, some bad, some awful.

@zeskorion
Copy link
Contributor Author

Again, I really think you're underestimating how huge an impact messing with Nanites in the way that you've coded has. Nanite programming generally relies on precision, and removing that precision removes any reason to use the Nanite symptoms.
I have yet to see a single instance of a Scientist working with Nanites combine their efforts with a Virologist. I'm sure it happens on rare occasion, but certainly not often enough to warrant the nerfs you've prescribed. If I were to work with Nanites, why would I ever want to introduce a chance of critical failure to them?
Also:
"fever is one of the best stat symptoms. I did that change with the express purpose of getting people to use other symptoms instead, like the ones i buffed"
Removing utility and functionality from things will always attract my ire.
I really wouldn't want to see this PR merged, frankly. You bundle so many different changes in - some good, some bad, some awful.

nanite symbiosis is insanely strong when it comes to nanite generation, . Fever is the best low-level stat symptom as well, being a no-brainer to shove on many diseases.

@zeskorion
Copy link
Contributor Author

either way, pr is finished

@imw-Oculus
Copy link

imw-Oculus commented Jul 31, 2020

I feel like you're ignoring half of what I'm posting. Yes - a niche positive symptom has positive utility. No, you shouldn't nerf it in such a way that it makes it outright stupid to include in a disease, because it would inevitably harm the host.
To quote myself:

Again, I really think you're underestimating how huge an impact messing with Nanites in the way that you've coded has. Nanite programming generally relies on precision, and removing that precision removes any reason to use the Nanite symptoms.

If you wanted to nerf the symptom, reduce the rates at which nanite production is buffed, or they're consumed. Don't introduce a chance of error.
Oh, and atomize your PR's.

@zeskorion
Copy link
Contributor Author

zeskorion commented Aug 1, 2020

I feel like you're ignoring half of what I'm posting. Yes - a niche positive symptom has positive utility. No, you shouldn't nerf it in such a way that it makes it outright stupid to include in a disease, because it would inevitably harm the host.
To quote myself:

Again, I really think you're underestimating how huge an impact messing with Nanites in the way that you've coded has. Nanite programming generally relies on precision, and removing that precision removes any reason to use the Nanite symptoms.

If you wanted to nerf the symptom, reduce the rates at which nanite production is buffed, or they're consumed. Don't introduce a chance of error.
Oh, and atomize your PR's.

N. if i atomize, viro will get too powerful cuz buffs'll be merged and nerfs wont. People accuse me of only doing viro buffs too much already

Co-authored-by: PowerfulBacon <jakeymortlock@gmail.com>
@zeskorion
Copy link
Contributor Author

shut up travis

@zeskorion zeskorion removed the Removal label Aug 3, 2020
@imw-Oculus
Copy link

imw-Oculus commented Aug 4, 2020

I don't have a problem with small nerfs, but the way that you've nerfed things is kinda terrible. It'd also be nice to have you respond to the objections I brought up. Additionally, that's a terrible reason to not atomize. I stand by my above points.

@zeskorion
Copy link
Contributor Author

I don't have a problem with small nerfs, but the way that you've nerfed things is kinda terrible. It'd also be nice to have you respond to the objections I brought up. Additionally, that's a terrible reason to not atomize. I stand by my above points.

like i said before, nanites are very good, and nano-symbiosis brings em over the edge. making it slightly detriment nanites by rogue activation and deactivation puts it on par with the mitosis program, which has similar regeneration with similar downsides

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me when wiki changes done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants