Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] The great resprite: Suits! engineering ones. #2677

Merged
merged 19 commits into from
Dec 17, 2020

Conversation

SomeAngryMiner
Copy link
Contributor

@SomeAngryMiner SomeAngryMiner commented Oct 11, 2020

About The Pull Request

its that time of the year again.
another part of the resprite wave, last one from the original pr: suits!
hardsuits are cool, pretty cool, but... they are variations of the same deadspace reference, so decided to spice that up.
You can see some of the differences here.

also changed: uniforms of the engineering department.

removed a duplicate riot armor icon, dunno what it was doing there.

gasmasks got a new groove, as seen in the picture below.

great engineering backpacks by @Agameofscones , inhands included!.

sec hardsuit resprites by @thatguythere03 , now they look more heavy duty than before, and overall more intimidating.

as per requested, the atmos suit was changed, as well.

skinsuit codersprite replaced.

every snowcoat got replaced.

honestly check the icon diffs i might have forgotten something

im mentally prepared for travis to eat my face off with 1000 conflicts :).

image
image
image
image
image

Why It's Good For The Game

new suits, visual distinction of bee, wiping codersprites, what i always say on these kind of PRs.

Changelog

🆑 Azlan, Thatguythere03, Triiodine
imageadd: resprites engineering suits, radsuits, gasmask, engineering uniforms, workboots, sec hardsuits, snowcoats, skinsuits, engineering backpacks, insuls and magboots.
imagedel: no more duplicate riot armor on the icon files.
/:cl:

@TeomanTheGreat
Copy link
Contributor

I dunno about this one. Some of the sprites look good but others don't fit in with the artstyle of the rest of the game.

@SomeAngryMiner
Copy link
Contributor Author

this bundle of PRs is literally for giving the game a cohesive style, bruh.

@SomeAngryMiner
Copy link
Contributor Author

SomeAngryMiner commented Oct 11, 2020

image
image

top is the new backpacks, second image (bottom row) is the new sec hardsuits.

@Doosteroni
Copy link

Doosteroni commented Oct 11, 2020

You good mate? I think you got those two images reversed

Edit: ohhhh you are probably Australian that makes a lot more sense

@SomeAngryMiner
Copy link
Contributor Author

shshshsh, im not crazy (yet), fixed it.

@AnjelicaChaykovsky
Copy link

new sec hardsuits.

Hardsuits ? So both of them, hos too ?
Which are the coolest on station ?
current hardsuits have much better quality and better clarity than ones you want to add... And even the kinda bad hardsuits which could use a upgrade cmo for example ? You dont upgrade them.

You shouldnt add new sprites to add like you said yourself " muh style" But instead make them actually better..

@SomeAngryMiner
Copy link
Contributor Author

SomeAngryMiner commented Oct 11, 2020

Hardsuits ? So both of them, hos too ?

both of them, yeah. The HoS one looks like an upgraded, more plated version of sec hardsuits as well.

Which are the coolest on station ?

could argue that with the standard security hardsuit, but HoS does have a strong quality

current hardsuits have much better quality and better clarity than ones you want to add... And even the kinda bad hardsuits which could use a upgrade cmo for example ? You dont upgrade them.

To easily keep track of all changes im making, im doing it by "modules", example, a PR with all tools, then one with all stockparts, and now, one with all engineering suits, Medical is later down the road. Reason why sec hardsuits are there is because thatguy
did them, and had no way to PR them, so i slapped them in, less work for the future.

If you have a problem with the new sec hardsuits, give us a list of what's wrong and we'll get it fixed before the merge, its pretty easy.

You shouldnt add new sprites to add like you said yourself " muh style" But instead make them actually better..

Yeah, i thought that engineer suits were aging, and since they were just carbon copies of each other but with different base colors, a good twist could be good. Style is secondary, but still an objective of the PRs.

@AnjelicaChaykovsky
Copy link

Hardsuits ? So both of them, hos too ?

both of them, yeah. The HoS one looks like an upgraded, more plated version of sec hardsuits as well.

Which are the coolest on station ?

could argue that with the standard security hardsuit, but HoS does have a strong quality

current hardsuits have much better quality and better clarity than ones you want to add... And even the kinda bad hardsuits which could use a upgrade cmo for example ? You dont upgrade them.

To easily keep track of all changes im making, im doing it by "modules", example, a PR with all tools, then one with all stockparts, and now, one with all engineering suits, Medical is later down the road. Reason why sec hardsuits are there is because thatguy
did them, and had no way to PR them, so i slapped them in, less work for the future.

If you have a problem with the new sec hardsuits, give us a list of what's wrong and we'll get it fixed before the merge, its pretty easy.

You shouldnt add new sprites to add like you said yourself " muh style" But instead make them actually better..

Yeah, i thought that engineer suits were aging, and since they were just carbon copies of each other but with different base colors, a good twist could be good. Style is secondary, but still an objective of the PRs.

Basically what you did with old crappy parts was great, the same with some of the tools - that needed an upgrade.
But hardsuits are already cool unlike the outdated parts or tools.
2020-10-11_21-02-41

this wintercloak for example is amazing from color palette to its balance, its very crisp, i could surely say thats cool.
And i wish the hardsuits would follow its example.
And the sec hardsuit, first one could replace regular one, but hos ? Hos one should be 10 times cooler like it currently is.
Dont just add slight color difference and call it done

@SomeAngryMiner
Copy link
Contributor Author

SomeAngryMiner commented Oct 11, 2020

that security hardsuit up there in the sheet aint the HoS hardsuit, its a color variation of the sec hardsuit (didnt make it ingame)
image
this is the actual HoS hardsuit.
If more people seem to have a problem with the new sec hardsuits, ill ask thatguy to tweak them.

@r1ks-iwnl
Copy link
Contributor

I don't like last 2 images of the sec and hos hardsuit since the helmet looks like it points towards the ground and sticks out in the back too much.

@zeskorion
Copy link
Contributor

I really, really dont like changing the gas mask. rest is fine though

@TeomanTheGreat
Copy link
Contributor

I really, really dont like changing the gas mask. rest is fine though

This

@PowerfulBacon
Copy link
Member

CE jumpsuit looks more like virology

@thatguythere03
Copy link
Contributor

We're working on modifying the helmet and overall palette for the new security hardsuit sprites.
For some reason when I originally made the sprites, I used the existing hardsuit palette for the standard sec suit on the new ones, and the made some super dark black palette for the HOS variant.
I have no idea what I was thinking, but Az is taking care of the colors and I handed him a modified helmet design, so it should be handled.

@SomeAngryMiner
Copy link
Contributor Author

SomeAngryMiner commented Oct 13, 2020

image

final product of the tweaks on regular sec hardsuit, we are still working on HoS so far.

@Moccha-Bee
Copy link
Contributor

speed merge?

@SomeAngryMiner
Copy link
Contributor Author

time to get yelled at, boys.
testmerge worthy now.

@Isy232
Copy link
Contributor

Isy232 commented Nov 6, 2020

To be honest I like all of them

However I do not think the yog canisters fit our asthetic as well, they look a little too 3D.

@Penwin0
Copy link
Member

Penwin0 commented Nov 8, 2020

The new CE jumpsuit does not fit the engineering asthetic at all looking more like a virologist, additionally the sprites for the advanced magboots and the CE hardsuit legs are exactly the same meaning if you have both on you can not tell if the boots are on or off something that was visible before

@Trash0077
Copy link

Whenever you make hardsuits widen at the top (engi and ce) it looks like they are leaning forward in an unnatural way, looks very bad.

@TheFakeElon
Copy link
Contributor

TheFakeElon commented Nov 8, 2020

space arthritis 😔

@Crossedfall Crossedfall added Test Merged This PR is currently in rotation and removed Needs Testmerge labels Nov 10, 2020
@Crossedfall
Copy link
Member

Currently test merged on Sage

@Crossedfall Crossedfall removed the Test Merged This PR is currently in rotation label Nov 10, 2020
@PowerfulBacon PowerfulBacon reopened this Nov 19, 2020
@PowerfulBacon
Copy link
Member

I'd merge this but I really don't like how the CE jumpsuit looks like a virology suit

@Crossedfall
Copy link
Member

Re: CE - I think a more cream color would probably look a bit better. The current coloring is just a bit too... Sterile.

@PowerfulBacon PowerfulBacon added Test Merged This PR is currently in rotation and removed Test Merged This PR is currently in rotation labels Dec 15, 2020
@PowerfulBacon PowerfulBacon merged commit 5d122f0 into BeeStation:master Dec 17, 2020
@SomeAngryMiner SomeAngryMiner deleted the suits branch December 17, 2020 17:29
@BitBite112
Copy link

No one liked the gas mask, would you please revert it? We all agreed it was iconic and should be untampered with.

@Vexylius
Copy link
Contributor

those new sec hardsuits looks like kinda like they were syndie

@hotimep
Copy link

hotimep commented Dec 18, 2020

do not resprite the gas mask
it is like removing assistant from the game

@BeeStation BeeStation locked as resolved and limited conversation to collaborators Dec 18, 2020
@ike709
Copy link
Member

ike709 commented Dec 18, 2020

I'm tired of seeing gas mask replies when the old ones are already being re-added in a separate open PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet