HoS gun beacon: make your choice from the X-01, X-02 and X-03 guns #2859

Victor239 · 2020-10-30T17:49:26Z

About The Pull Request

Revived Cae's original X-02 PR with some tweaks.

Swaps the HoS gun for a beacon which allows you to choose your gun, includes the original X-01 as well as the new X-02 and X-03 experimental models. Allows you to choose a gun based on your needs, whether it's for high utility in a small amount of space, high impact ballistics or the versatility of the existing X-01.

X-02 MultiPhase Energy Gun

Energy-based gun focused around utility ammo. Lacks lethal ammo.

Ion: Exactly the same as the ion rifle rounds. 12 shots, 3 shots/second.
Freeze: Same as the temperature gun's only useful setting, but with a lower rate of fire. 20 shots, 3 shots/second.
Netting: Same as DRAGnet netting i.e. the spreading shots. 12 shots, 2 shots/second.

X-03 MultiPhase Hybrid Gun

Hybrid ballistics created from an internal 3D printer. Lacks non-lethals and most utility ammo.

.454 High Velocity: Does 25 brute damage per shot with low AP and moves significantly faster than regular projectiles. 10 shots, 2 shots/second.
.454 Anti Riot/Plastic: Semi-lethal, does 5 brute and 15 stamina damage per pellet with 3 pellets per shot. 12 shots, 4 shots/second.
.454 Breaching: Renamed 12g breaching slugs. Good for busting down doors and windows, terrible at everything else. 12 shots, 3 shots/second.

Why It's Good For The Game

More interesting variety by being able to switch up your gun from round-to-round. Encourages using a diversity of ammo you might otherwise ignore. Helps you to regret which type you chose every time you enter deadchat.

Changelog

🆑
add: Adds the HoS gun beacon. Make your choice from the X-01, X-02 and X-03 guns.
balance: HoS gun now uses a mindshield firing pin.
/:cl:

1

TeomanTheGreat · 2020-10-30T18:02:21Z

This doesn't mess with the tot objective right?

Victor239 · 2020-10-30T18:03:56Z

Yeah that's fine.

PowerfulBacon · 2020-10-30T19:09:14Z

Why does an energy gun shoot shotgun pellets

Autisem · 2020-10-30T19:31:44Z

Why does an energy gun shoot shotgun pellets

bluespace

AnjelicaChaykovsky · 2020-10-30T20:40:04Z

@Victor239 what about making different sprites for x03 and x02

ballistic model could be for example red and cool

i mean it make sense that it would look different since laser and ballistic need different parts

i could finish this sprite and make x02 too

Cenrus · 2020-10-30T20:44:37Z

please get rid of the tazer mode.

Moccha-Bee · 2020-10-30T20:45:01Z

please get rid of the tazer mode.

why?

AnjelicaChaykovsky · 2020-10-30T20:46:42Z

please get rid of the tazer mode.

why?

its pretty shit and each shot is 33% ammo

Moccha-Bee · 2020-10-30T20:47:18Z

please get rid of the tazer mode.

why?

its pretty shit and each shot is 33% ammo

So what, i like using the taser mode to insta stun the criminal scum 😎

AnjelicaChaykovsky · 2020-10-30T20:50:23Z

So what, i like using the taser mode to insta stun the criminal scum 😎
then they get up from that knockdown half a second later

Moccha-Bee · 2020-10-30T20:51:23Z

So what, i like using the taser mode to insta stun the criminal scum 😎
then they get up from that knockdown half a second later

the taser stun lasts longer, and i just disabler/stunbaton them afterwards. Its great way to non-lethal way to stopp people who are fleeing

Cenrus · 2020-10-30T21:29:40Z

25 damage from the HoS gun is far too much considering Stetchkins do 20 and need to be reloaded with real ammo that can't be recharged.

AnjelicaChaykovsky · 2020-10-30T21:40:28Z

25 damage from the HoS gun is far too much considering Stetchkins do 20 and need to be reloaded with real ammo that can't be recharged.

(looks at roundstart riot shotgun that can hold shotgun slugs and crit people in two shots with great accuracy)

Victor239 · 2020-10-31T06:01:58Z

@PowerfulBacon energy to matter conversion is prevalent on station, from chem dispensers to bluespace miners. A 3D printer for ammo is no different.

@AnjelicaChaykovsky different sprites sounds good, I'll probably bug Azlanon for that though.

Taser mode - it's short-range and high energy cost make it situational, even then shotguns are comparably good and better if examining the warden's combat shotgun even. I might reduce the fire rate for that mode however.

@Cenrus when choosing the ammo for the X-03 the warden's shotgun was my main point of comparison, and in this their shotgun is still stronger however it lacks the versatility of the X-03.

MrHorizons · 2020-10-31T07:06:51Z

I'd say you should rename the X-03 to the X-03 MultiPhase Ballistic Gun, since it's only, well, ballistics.

WhyIsCaeciliusTaken · 2020-10-31T09:15:21Z

@Cenrus the stechkin does 30. The detective's revolver does 25 and also has the same rate of fire as this new gun. Only difference is the faster travelling bullets.

AnjelicaChaykovsky · 2020-10-31T14:30:33Z

@AnjelicaChaykovsky different sprites sounds good, I'll probably bug Azlanon for that though.

ok rest in peace my effort

TheFakeElon · 2020-11-02T01:02:24Z

We should be removing non-antag ballistics, not adding more 😔

Blueturbo47 · 2020-11-02T23:31:11Z

Don't you need to change the trator objective too? If a tot has to steal the gun from the hos and it's already changed they won't be able to greentext.

TheFakeElon · 2020-11-03T00:29:11Z

@Blueturbo47 it won’t

ZombiesVsPlants · 2020-11-03T23:38:01Z

round start ion gun with alternate settings
shoots 3 bolts per second
fits in backpacks

Rip malf/nukie borgs

eeSPee · 2020-11-07T10:47:39Z

You could have the ballistic one recharge with Iron, so it can't print ammo out of raw energy.

TheFakeElon · 2020-11-09T01:28:26Z

@AnjelicaChaykovsky the ballistic gun looks like something from evangallion

BrotherHangyul · 2020-11-22T13:41:56Z

Me likey. Maybe make the X-03 sprite a bit more revolver/big-irony.

ToasterBan · 2020-11-22T13:42:10Z

i hate sec and i still love this

BrotherHangyul

Seems like it would work fine and add new content to the game.

ike709 · 2020-11-28T21:22:04Z

code/game/objects/items/miscellaneous.dm

+/obj/item/choice_beacon/hosgun/generate_display_names()
+	var/static/list/hosgun_item_list
+	if(!hosgun_item_list)
+		hosgun_item_list = list()
+		var/list/templist = typesof(/obj/item/gun/energy/e_gun/hos)
+		for(var/V in templist)
+			var/atom/A = V
+			hosgun_item_list[initial(A.name)] = A
+	return hosgun_item_list


Bad code is bad.

It's a copy and paste of the other choice beacons

Doesn't make it less bad.

I'm willing to put this PR to a vote but it won't be merged until after you've cleaned up this proc.

ike709 · 2020-11-28T21:22:30Z

I'll only consider this PR if the guns are DNA-locked to the HoS so a tider can't robust them and steal it.

Victor239 · 2020-11-29T19:33:39Z

I'd hesitate to add a mindshield firing pin let alone a DNA locked firing pin for the HOS gun, and I say this as a security main.

Killing the HOS or robbing their locker is a time honoured tradition, as well as an antag objective. Firing pins are quite hard to get a hold of in addition to obtaining their gun. For 95% of antags who obtain the gun it'll be unusable for them because they lack the pin.

Even the warden's combat shotgun and captain's antique laser gun use standard firing pins so I don't see the reasoning for such an antag nerf.

BrotherHangyul · 2020-11-30T13:31:32Z

Maybe make the gun emaggable?

TeomanTheGreat · 2020-11-30T23:03:32Z

Maybe make the gun emaggable?

Why would it need to be emaggable?

BrotherHangyul · 2020-12-24T13:03:46Z

merge

Victor239 · 2021-01-11T18:02:35Z

@park66665 review instead of marking stale

park66665 · 2021-01-11T20:21:59Z

Did you convince ike?

Victor239 · 2021-01-12T05:53:00Z

@ike709 see my reply to DNA lock feedback

ike709 · 2021-01-14T20:11:07Z

I'll compromise: Mindshield firing pin.

Cenrus · 2021-01-14T22:17:31Z

Why should a traitor not be allowed to use the gun they put in so much effort to get their hands on? Or at least, not without a mindshield which is arguably even harder to obtain.

code/modules/projectiles/ammunition/energy/special.dm

code/modules/projectiles/projectile/bullets/special.dm

Victor239 · 2021-01-17T17:15:13Z

Added the requested mindshield firing pin

code/game/objects/items/miscellaneous.dm

TheFakeElon · 2021-01-25T06:15:37Z

Key turned, overall maintainer verdict voted in favour this PR being closed. Feel free to re-open after getting approval from a maintainer, preferably after some balance changes are made

Victor239 · 2021-01-25T06:22:49Z

What balance changes? I already made all the ones Ike requested.

ike709 · 2021-01-25T06:39:19Z

🔑

Victor239 added 2 commits October 30, 2020 16:01

Initial commit

aff2d3f

1

Split HoS gun into 3 types and added a beacon for it

bad99e0

solid-octo-guacamole bot added the Feature label Oct 30, 2020

PowerfulBacon closed this Nov 24, 2020

PowerfulBacon reopened this Nov 24, 2020

BrotherHangyul reviewed Nov 26, 2020

View reviewed changes

ike709 reviewed Nov 28, 2020

View reviewed changes

park66665 added the Stale label Jan 9, 2021

park66665 removed the Stale label Jan 15, 2021

Added a mindshield firing pin to HoS gun

d9e6a46

park66665 reviewed Jan 16, 2021

View reviewed changes

code/modules/projectiles/ammunition/energy/special.dm Outdated Show resolved Hide resolved

code/modules/projectiles/projectile/bullets/special.dm Outdated Show resolved Hide resolved

Removed HoS TRAC shells

424117d

solid-octo-guacamole bot added the Balance/Rebalance label Jan 17, 2021

ike709 reviewed Jan 17, 2021

View reviewed changes

code/game/objects/items/miscellaneous.dm Outdated Show resolved Hide resolved

ike709 added the Voting label Jan 17, 2021

Removed static

1d162e4

ike709 added Vote Passed and removed Voting labels Jan 18, 2021

francinum added the Stale label Jan 25, 2021

TheFakeElon closed this Jan 25, 2021

HoS gun beacon: make your choice from the X-01, X-02 and X-03 guns #2859

HoS gun beacon: make your choice from the X-01, X-02 and X-03 guns #2859

Conversation

Victor239 commented Oct 30, 2020 • edited

About The Pull Request

X-02 MultiPhase Energy Gun

X-03 MultiPhase Hybrid Gun

Why It's Good For The Game

Changelog

TeomanTheGreat commented Oct 30, 2020

Victor239 commented Oct 30, 2020

PowerfulBacon commented Oct 30, 2020

Autisem commented Oct 30, 2020

AnjelicaChaykovsky commented Oct 30, 2020 • edited

Cenrus commented Oct 30, 2020

Moccha-Bee commented Oct 30, 2020

AnjelicaChaykovsky commented Oct 30, 2020

Moccha-Bee commented Oct 30, 2020

AnjelicaChaykovsky commented Oct 30, 2020

Moccha-Bee commented Oct 30, 2020 • edited

Cenrus commented Oct 30, 2020 • edited

AnjelicaChaykovsky commented Oct 30, 2020

Victor239 commented Oct 31, 2020

MrHorizons commented Oct 31, 2020

WhyIsCaeciliusTaken commented Oct 31, 2020

AnjelicaChaykovsky commented Oct 31, 2020

TheFakeElon commented Nov 2, 2020

Blueturbo47 commented Nov 2, 2020

TheFakeElon commented Nov 3, 2020

ZombiesVsPlants commented Nov 3, 2020

eeSPee commented Nov 7, 2020

TheFakeElon commented Nov 9, 2020 • edited

BrotherHangyul commented Nov 22, 2020 • edited

ToasterBan commented Nov 22, 2020

BrotherHangyul left a comment

Choose a reason for hiding this comment

ike709 Nov 28, 2020

Choose a reason for hiding this comment

Victor239 Jan 11, 2021

Choose a reason for hiding this comment

ike709 Jan 14, 2021

Choose a reason for hiding this comment

ike709 Jan 17, 2021 • edited

Choose a reason for hiding this comment

ike709 commented Nov 28, 2020

Victor239 commented Nov 29, 2020

BrotherHangyul commented Nov 30, 2020

TeomanTheGreat commented Nov 30, 2020

BrotherHangyul commented Dec 24, 2020

Victor239 commented Jan 11, 2021

park66665 commented Jan 11, 2021

Victor239 commented Jan 12, 2021

ike709 commented Jan 14, 2021

Cenrus commented Jan 14, 2021

Victor239 commented Jan 17, 2021

TheFakeElon commented Jan 25, 2021

Victor239 commented Jan 25, 2021

ike709 commented Jan 25, 2021

Victor239 commented Oct 30, 2020 •

edited

AnjelicaChaykovsky commented Oct 30, 2020 •

edited

Moccha-Bee commented Oct 30, 2020 •

edited

Cenrus commented Oct 30, 2020 •

edited

TheFakeElon commented Nov 9, 2020 •

edited

BrotherHangyul commented Nov 22, 2020 •

edited

ike709 Jan 17, 2021 •

edited