[PORT] Ports tgstation/tgstation#51453 real quick #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes turf atmos getting deleted. * Moves the gas transfer procs to the gas mixture. * Fixes emp act to behave like before * Fixes tanks exploding
park66665
changed the title
|
PS: I felt eerie how the Bee pumping code was, like, 100% identical to tg except it was C++ monstermos compatible. We still live under the shadow of dunc and Co. |
|
You stand on the work of those who came before |
PowerfulBacon
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#51453
I can't tell with 100% certainty (I am 75% certain that it caused currently unreported problems) if #3089 fucked Beecode, I didn't get reports about it, but I want to make sure, and I didn't like internal pumps from the moment I saw it in the first place; it created ridiculous amount of useless pipenets: about 300.
This PR also includes suppression of warning-like runtimes happening while init dir caching, which I didn't even know til I investigated a runtime reported by Archanial, but this part is trivial.
There are other pipenet fixes (hint: that won't be porting tgstation/tgstation#55514) I have in mind (read: still can't decide how to fix), but I am sure they can wait, and I am going to a start week-long hiatus soon(tm). I am not going to include them here.
Why It's Good For The Game
This should result in less broken atmos. But... is "less broken atmos" possible???
Changelog
馃啈 nemvar
fix: fixed atmos component code (again)
/:cl: