Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds credit cost to printing items from the autolathe #3710

Closed
wants to merge 3 commits into from
Closed

Adds credit cost to printing items from the autolathe #3710

wants to merge 3 commits into from

Conversation

mudzbe
Copy link

@mudzbe mudzbe commented Feb 22, 2021

About The Pull Request

Adds a credit cost to printing items from the auto-lathe. Auto-lathes bill to your ID/budget if you have it, otherwise you stink. Emagged auto-lathes don't require credits to be payed, though NT wont like that. Auto-lathes off-station will be set to this setting. Silicons using the auto-lathe will bill to the civilian budget. Pretty pictures with some stats in the comments. These are all solely based off their existing material costs, so lots of the costs don't make sense and I am going to fix them.

Why It's Good For The Game

Credits have almost no value and by extension budget cards. Get them nerds to spend their hard earned money which accumulates in their IDs, untouched, unwanted. :(

This shit is blowing off, here's my soundcloud

austation/austation#3092

CERTIFIED AUSTATION CLASSIC

Changelog

馃啈
add: Added a credit cost to building items in the autolathe, circumvented by emagging
/:cl:

mudzbe added 2 commits February 22, 2021 18:04
Ported from AUStation #3092
@mudzbe
Copy link
Author

mudzbe commented Feb 22, 2021

Pretty pictures as promised:
Annotation 2021-02-22 173358
Annotation 2021-02-22 173543
Annotation 2021-02-22 173600
Annotation 2021-02-22 173634
Annotation 2021-02-22 173651
Annotation 2021-02-22 173728
Annotation 2021-02-22 173750
Annotation 2021-02-22 173843
Annotation 2021-02-22 173900

@RDS88-beeman
Copy link
Contributor

insert funny jontron gif here

@PowerfulBacon
Copy link
Member

Wait till someone prints, enable queue mode, drain their money

@mudzbe
Copy link
Author

mudzbe commented Feb 22, 2021

could someoene plz say why they thumbs down my PR, my rebbit karma is tanking. If it's for the current item costs I said it's going to change ok? :(

@amidoingitright
Copy link
Contributor

time for the assistants to commit even more crime to steal tools

@bloons3
Copy link
Contributor

bloons3 commented Feb 22, 2021

This would need to come after most of TG's economy fix PRs, since this would either be trivial (costs too low) or blocking (costs too high).

Look at https://github.com/tgstation/tgstation/pulls?q=is%3Apr+Arconomy and

Copy link
Contributor

@TheFakeElon TheFakeElon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, there should probably be something in place prevent someone nuking someone else's balance as bacon mentioned.

code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
@TheFakeElon
Copy link
Contributor

Oops, draft PR. Oh well xd

Free code, thanks elon

Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>
@mudzbe
Copy link
Author

mudzbe commented Feb 22, 2021

This would need to come after most of TG's economy fix PRs, since this would either be trivial (costs too low) or blocking (costs too high).

Look at https://github.com/tgstation/tgstation/pulls?q=is%3Apr+Arconomy and

What was the last part? It was cut off

@mudzbe
Copy link
Author

mudzbe commented Feb 22, 2021

time for the assistants to commit even more crime to steal tools

This PR was sponsored by NanoTrasen's class warfare department. You see, if the assistants are too busy fighting science/cargo + security that means they wont have the energy to fight NT. NT gets money, the unwashed rabble fight each other, it's a win win.

@Effemu
Copy link

Effemu commented Feb 22, 2021

so basically this PR enables "open door" policy for engineering, science and cargo, against their will and makes tiding completely legal later in the round when station gets fucked

@TheFakeElon
Copy link
Contributor

so basically this PR enables "open door" policy for engineering, science and cargo, against their will and makes tiding completely legal later in the round when station gets fucked

馃

data["acceptsDisk"] = TRUE

var/static/list/ore_values = list(iron = 1, glass = 1, copper = 5, plasma = 15, silver = 16, gold = 18, titanium = 30, uranium = 30, diamond = 50, bluespace = 50, bananium = 60)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/obj/item/stack/ore has var/points you can use that instead of list.

@ivanmixo
Copy link
Contributor

12 fucking credits for a single light bulb?

@That0nePerson
Copy link
Contributor

Each of these costs needs to be perfectly, perfectly set or else this will have either no effect due to low cost or it'll completely stop everyone from getting tools unless sci is there to print them from the protolathe

@PowerfulBacon
Copy link
Member

馃攽

@LivingBatteryBox
Copy link
Contributor

This PR is awful conceptually, the whole point of an autolathe is to spend mats instead of credits. If you want people to pay for minor things, then you should just add them to the goodie crates in cargo (and if we don't have those just port em). Also, inb4 some random assistant law 2's a borg to drain the civilian budget by printing 500 shotgun shells.

@mudzbe
Copy link
Author

mudzbe commented Feb 23, 2021

This PR is awful conceptually, the whole point of an autolathe is to spend mats instead of credits. If you want people to pay for minor things, then you should just add them to the goodie crates in cargo (and if we don't have those just port em).

But is that point good in the first place? Also I don鈥檛 think that was the point in the first place. I can kinda see what you mean for tools, but there is a seperate PR by someone else to increase costs on vendors so having tools from the autolathe be free, would partly undermine it too. It鈥檚 not like people have much else to spend money on. It鈥檚 important to remember the autolathe doesn鈥檛 print exclusively tools. For example it prints modular receivers for guns, ammo, weapons like the hatchet and flamethrower. For those in particular, credit costs make a lot more sense, so that the only factor when printing good things like them isn鈥檛 whether or not the station has mats.

Also, inb4 some random assistant law 2's a borg to drain the civilian budget by printing 500 shotgun shells.

Borgs have agency to decide whether to permit a law 2 request, this is a pretty bad example because shotgun shells cause harm. But regardless of the item, borgs can decide whether or not the cost of the request may impact the ability for harm prevention, like buying guns during a blob or xeno infestation. In the same way a borg can deny a order to bring an assistant a department budget for no reason.

@mudzbe
Copy link
Author

mudzbe commented Feb 23, 2021

If you all don鈥檛 like the idea of the whole thing being monetised, I could only stick the credit cost on the weapons/ammo section and then tweak it so it鈥檚 reasonable. I think this ideas a bad call however. Stuff like this was a big reason why I made this a draft PR, so I could get feedback. Every cost of the items is going to change anyways, maybe putting in the pictures in this state was misleading, since it鈥檚 very likely it won鈥檛 look like that when I get around to changing it.

@amidoingitright
Copy link
Contributor

stick it on ammo then it'll be fairer

@PowerfulBacon
Copy link
Member

Even if our economy was balanced, HOP assigned jobs adjusted paychecks, assistants didnt get 0 credits while any other job gets thousands and every single item was manually balanced I still think this is a bad idea.

@ike709
Copy link
Member

ike709 commented Feb 23, 2021

OP is repobanned.

@ike709 ike709 closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet