Modernizes TGUI #4219

Sinestia · 2021-05-04T03:34:16Z

About The Pull Request

ports tgstation/tgstation#54567
tgstation/tgstation#56080
tgstation/tgstation#56225

TGUI Changes for Coders

Stack component replaces flex and generally replaces it, read more here
Storybook.js has been introduced, described in the above link.

bin/tgui ran with flags is more robust at handling issues for you, remember to run --lint and --fix when submitting something (because I sure as hell kept forgetting and it makes you look bad anyways.)

Fragment without a key is replaced with <>.

Typescript 4.2 can now be utilized for tgui components. Unit tests can be ran using Jest. Described here

Custom SVG fonts can be utilized now! Just throw them in the tgui icon's directly and then you can utilize them in your scripts. This is described here

A prettierrc exists now, for those who care. Along with multiple linter and vscode changes in general.

Resizable as a window property is dead, all windows are resizable by default now.

Some people have issues where their build differs from what the repo generates in the CIs, to fix this I believe you need to clear your untrackeds
you can do this with git clean -xdf on your tgui folder.

edit: on further investigation, it looks like some files have CRLF line endings instead of LF which they really shouldn't. Pulled straight from the repo, they're LF. This is the best lead I can find honestly. Ping me Ithiria#9193 if there's issues or to confirm that any of this works or something.

Why It's Good For The Game

~~No unnecessary merge conflicts with tgui PRs. ~~ lol use a bot

Newer TGUI

Typescript

Custom icons

Further monopolization of our lord and saviour vscode.

Changelog

🆑 Stylemistake, Cyberboss, SpaceManiac, other TG coders, Froststahr port.
code: TGUI has been upgraded to 4.3 and now includes typescript.
code: Custom SVG icons are now easy to do as well.
fix: All tgui windows will resize automatically, and can now be resized as will.
server: TGS will require adaptation.
/:cl:

ike709 · 2021-05-04T04:03:36Z

There's definitely more follow-up PRs.

Sinestia · 2021-05-04T04:03:45Z

oh. Fixing git tasks was that easy

Sinestia · 2021-05-04T04:04:42Z

There's definitely more follow-up PRs.

Yep, will get them

Only thing I think I will leave out is tgui 4.3, it's big enough that I think it should be done separately.

ike709 · 2021-05-04T04:18:41Z

If there's CBT changes in the 4.3 PR then get those but otherwise yes you can ignore 4.3.

Follow-up to fix the failing Docker CI on master. - Reorganize the entire Dockerfile to be more readable - Inline the tgstation/byond Dockerfile into our own, so we can change the base distro at will - Also allows us to trash the dependencies.sh<->Dockerfile hack - Use 32-bit libs on a 64-bit distro so that we can download and run recent 64-bit Node binaries - Call tools/build/build rather than DreamMaker directly

Sinestia · 2021-05-04T04:25:36Z

If there's CBT changes in the 4.3 PR then get those but otherwise yes you can ignore 4.3.

Seems like there's some important stuff in there, will have to get them then

edit: I Just went ahead and ported the whole thing, easier to do it all while I have the PR open instead of doing half
edit2: there's another PR I see, HmMm. Ill figure it later

ike709 · 2021-05-06T04:25:31Z

#4220

github-actions · 2021-05-10T04:48:41Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2021-06-18T02:08:13Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2021-06-23T23:49:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

BrumalLake · 2021-06-26T00:40:23Z

tell me this includes the tall ass atmos chamber monitoring consoles

github-actions · 2021-06-28T01:49:56Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sinestia · 2021-06-28T02:10:24Z

tell me this includes the tall ass atmos chamber monitoring consoles

You can think of this as being solely about the tgui backend

not any specific interfaces were changed beyond updating them

MCterra10 · 2021-06-28T02:17:55Z

Yolomerged

ike709 · 2021-06-28T03:08:35Z

It was testmerged on sage.

jupyterkat · 2021-06-28T12:24:34Z

ci checks fails on tgui regardless if the build is correct or not

BrumalLake · 2021-06-28T12:37:12Z

ci checks fails on tgui regardless if the build is correct or not

#4606
no it's somehow possible, not sure how i got it

Sinestia · 2021-06-28T12:47:30Z

ci checks fails on tgui regardless if the build is correct or not

Your cache/untrackeds are bad I believe

run git clean -xdf on your tgui folder

happened to me too

edit: on further investigation, it looks like some files have CRLF line endings instead of LF which they really shouldn't. Pulled straight from the repo, they're LF. This is the only tangible difference between my folder and that of someones who didn't work.

Ports the first two PRs. CBT works local

38c6e4c

github-actions bot added GitHub TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools labels May 4, 2021

Sinestia added 2 commits May 3, 2021 22:49

tchussi oops

319372c

linttobuild

b51e0f7

TGUI 43 plus hotfix 1

f16d298

Sinestia force-pushed the CBT branch from 50719d5 to f16d298 Compare May 5, 2021 10:24

Sinestia added 5 commits May 9, 2021 16:21

https://github.com/tgstation/tgstation/pull/58701

99b7e35

https://github.com/tgstation/tgstation/pull/56223

0ad5e4e

https://github.com/tgstation/tgstation/pull/56229

b651354

https://github.com/tgstation/tgstation/pull/56713

19033b6

https://github.com/tgstation/tgstation/pull/56797

024de0c

Sinestia force-pushed the CBT branch from 9def752 to 024de0c Compare May 10, 2021 01:05

Sinestia added 8 commits May 9, 2021 22:13

https://github.com/tgstation/tgstation/pull/57081/

df9e93c

https://github.com/tgstation/tgstation/pull/57154

3941b0f

https://github.com/tgstation/tgstation/pull/57251

444d228

https://github.com/tgstation/tgstation/pull/56269

1fe7887

https://github.com/tgstation/tgstation/pull/57277

4332c09

https://github.com/tgstation/tgstation/pull/57287

6853e0a

https://github.com/tgstation/tgstation/pull/57326

d867728

QF

8cb98ed

comp

7f45710

solid-octo-guacamole bot added the Fix label Jun 17, 2021

ike709 added the Needs Testmerge label Jun 17, 2021

github-actions bot added the Merge Conflict label Jun 18, 2021

Merge commit 'd1586277b5e51f6dd1014969f6b8f41b4178dbf7' into CBT

154471d

github-actions bot added Merge Conflict and removed Merge Conflict labels Jun 18, 2021

Merge commit '019b1147c22c5596a6eac922459122af703a57b7' into CBT

a7ccdf2

github-actions bot removed the Merge Conflict label Jun 24, 2021

github-actions bot added the Merge Conflict label Jun 28, 2021

ike709 removed the Needs Testmerge label Jun 28, 2021

Merge commit 'afd9d6467b2dcf7cad95db57ec86a079d02f5d92' into CBT

66d4462

github-actions bot removed the Merge Conflict label Jun 28, 2021

ike709 merged commit f2a0f51 into BeeStation:master Jun 28, 2021

ghost mentioned this pull request Jun 28, 2021

[MIRROR] Modernizes TGUI ReflectionDevs/Echo13-Alpha#549

Open

AustationBot mentioned this pull request Jun 28, 2021

[MIRROR] Modernizes TGUI austation/austation#3700

Merged

ss13-beebot added a commit that referenced this pull request Jun 28, 2021

Automatic changelog generation for PR #4219 [ci skip]

75df2a2

MNarath1 mentioned this pull request Jun 30, 2021

TGUI Stat Panel not loading #4686

Closed

Sinestia deleted the CBT branch July 27, 2021 19:28

TheGamerdk mentioned this pull request Nov 3, 2022

jamie stinks yogstation13/Yogstation#16349

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernizes TGUI #4219

Modernizes TGUI #4219

Sinestia commented May 4, 2021 •

edited

Loading

ike709 commented May 4, 2021

Sinestia commented May 4, 2021

Sinestia commented May 4, 2021 •

edited

Loading

ike709 commented May 4, 2021

Sinestia commented May 4, 2021 •

edited

Loading

ike709 commented May 6, 2021

github-actions bot commented May 10, 2021

github-actions bot commented Jun 18, 2021

github-actions bot commented Jun 23, 2021

BrumalLake commented Jun 26, 2021

github-actions bot commented Jun 28, 2021

Sinestia commented Jun 28, 2021

MCterra10 commented Jun 28, 2021

ike709 commented Jun 28, 2021

jupyterkat commented Jun 28, 2021

BrumalLake commented Jun 28, 2021

Sinestia commented Jun 28, 2021 •

edited

Loading

Modernizes TGUI #4219

Modernizes TGUI #4219

Conversation

Sinestia commented May 4, 2021 • edited Loading

About The Pull Request

TGUI Changes for Coders

Why It's Good For The Game

Changelog

ike709 commented May 4, 2021

Sinestia commented May 4, 2021

Sinestia commented May 4, 2021 • edited Loading

ike709 commented May 4, 2021

Sinestia commented May 4, 2021 • edited Loading

ike709 commented May 6, 2021

github-actions bot commented May 10, 2021

github-actions bot commented Jun 18, 2021

github-actions bot commented Jun 23, 2021

BrumalLake commented Jun 26, 2021

github-actions bot commented Jun 28, 2021

Sinestia commented Jun 28, 2021

MCterra10 commented Jun 28, 2021

ike709 commented Jun 28, 2021

jupyterkat commented Jun 28, 2021

BrumalLake commented Jun 28, 2021

Sinestia commented Jun 28, 2021 • edited Loading

Sinestia commented May 4, 2021 •

edited

Loading

Sinestia commented May 4, 2021 •

edited

Loading

Sinestia commented May 4, 2021 •

edited

Loading

Sinestia commented Jun 28, 2021 •

edited

Loading