Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tgui strip window from /tg/ #4840

Closed
wants to merge 10 commits into from

Conversation

BrumalLake
Copy link
Contributor

@BrumalLake BrumalLake commented Jul 16, 2021

About The Pull Request

Ports

Strip panel now uses tgui
Panel doesn't reopen when you finish an action now
Toggle internals button wont be having an icon until svg fonts get fixed
Adjusting jumpsuit function changed to our adjusting suit sensors function, as uniforms still cover your chest/arms while visually exposing your chest/having your sleeves rolled up
Small note, animated icons don't look very good

  • suit sensors button

Why It's Good For The Game

More responsive, well organized hud

Changelog

馃啈 lordScrubling, Mothblocks
add: tgui for stripping window
code: strippable element
/:cl:

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Jul 16, 2021
@ivanmixo
Copy link
Contributor

I'd rather we just modernize what we have now, it's what most of the playerbase is comfortable with.

@BrumalLake
Copy link
Contributor Author

BrumalLake commented Jul 16, 2021

I'd rather we just modernize what we have now, it's what most of the playerbase is comfortable with.

"don't make things better because people use the current versions"

@Cenrus
Copy link
Contributor

Cenrus commented Jul 16, 2021

Our strip menu is the same except for the Set sensors button, has it been implemented here

@BrumalLake
Copy link
Contributor Author

Our strip menu is the same except for the Set sensors button, has it been implemented here

damn, i have to figure out how to do that now

@BrumalLake BrumalLake marked this pull request as draft July 16, 2021 22:20
@Cenrus
Copy link
Contributor

Cenrus commented Jul 16, 2021

Shouldnt be too hard, look at how they made the adjust jumpsuit toggle on their UI.

@BrumalLake
Copy link
Contributor Author

Shouldnt be too hard, look at how they made the adjust jumpsuit toggle on their UI.

well, i'm gonna have to figure out how to place it somewhere else

@ivanmixo
Copy link
Contributor

I'd rather we just modernize what we have now, it's what most of the playerbase is comfortable with.

"don't make things better because people use the current versions"

I don't think this is better, is the thing.

@BrumalLake
Copy link
Contributor Author

probably gonna scrap adjusting uniforms for suit sensors, since it doesn't actually do anything except be cosmetic

@AnCopper
Copy link
Contributor

probably gonna scrap adjusting uniforms for suit sensors, since it doesn't actually do anything except be cosmetic

It's for surgery.

@BrumalLake
Copy link
Contributor Author

probably gonna scrap adjusting uniforms for suit sensors, since it doesn't actually do anything except be cosmetic

It's for surgery.

adjusting it doesn't change what parts it covers

@BrumalLake BrumalLake marked this pull request as ready for review July 17, 2021 00:50
@KubeRoot
Copy link
Member

probably gonna scrap adjusting uniforms for suit sensors, since it doesn't actually do anything except be cosmetic

It's for surgery.

adjusting it doesn't change what parts it covers

I want to mention, it does do that on tg and it'd probably be a good thing to port. Because of this, I think it shouldn't be removed from the UI.
I think defining a second alternateAction that appears in another corner, or maybe turning it into a list of alternate actions that are stacked in a corner, would work fine.

@BrumalLake
Copy link
Contributor Author

BrumalLake commented Jul 18, 2021

probably gonna scrap adjusting uniforms for suit sensors, since it doesn't actually do anything except be cosmetic

It's for surgery.

adjusting it doesn't change what parts it covers

I want to mention, it does do that on tg and it'd probably be a good thing to port. Because of this, I think it shouldn't be removed from the UI.
I think defining a second alternateAction that appears in another corner, or maybe turning it into a list of alternate actions that are stacked in a corner, would work fine.

I don't think adjusting is a feature worth doing, different jumpsuits have different adjusting sprites, spriters haven't been consistent in alternate sprites, some have their sleeves just rolled up
the only thing keeping it will do for now is fool people
how about readd it when you code it

i don't know tgui myself really

@francinum
Copy link
Contributor

...This is incredibly fucking ugly.

@ike709
Copy link
Member

ike709 commented Jul 19, 2021

Yeah this is pretty ugly, visually.

@BrumalLake
Copy link
Contributor Author

i see it now, seems like a good time for me to try to learn tgui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Feature TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants