Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts requirements to unlock jobs (Take two) #5004

Merged
merged 3 commits into from Aug 14, 2021

Conversation

Rukofamicom
Copy link
Contributor

@Rukofamicom Rukofamicom commented Aug 1, 2021

About The Pull Request

This PR adjusts the hours required to play Medical, Engineering and Science jobs. All of these jobs have a purpose to fulfil on the station that a legitimately new player will not be able to grasp. Additionally adds a minor barrier to make griefers much more apparent to admins observing them when they first connect, as well as players appropriately attempting to uphold access restrictions to their department.

Additionally tweaks a small amount of other jobs:

  • Virologist now requires ten hours of medical, due to how dangerous it is when mishandled. Players should be familiar with medbay in general before moving into the virology lab. This places it at half of the requirement for Chief Medical Officer, much like the Warden requires within Security.
  • Head of Personnel now requires ten hours played as command instead of service. The HoP is not just the Supply/Civilian head, but also in charge of handing out access across the station and the second in command, one step down from the Captain. Giving players such an elevated position as their first Head of Staff has caused a staggering amount of problems and this is the best solution to ensuring HoP are less inclined to hand out access they shouldn't.
  • AI now requires ten hours as cyborg instead of just four. AI is probably the single most powerful entity on the station, and should be vetted with a bit more experience in silicons before being granted the level of power and responsibility they are.
  • Brig Physician's requirements have been reduced to just two hours as normal crew, like the rest of the medical jobs.

Why It's Good For The Game

Keeps 100% new players out of important areas, and also makes things a little more difficult for potential griefers.

Changelog

🆑
tweak: Medical, Engineering and Science jobs now require two hours played
tweak: Brig Physician now only requires two hours as normal crew
tweak: AI now requires 10 hours as a cyborg
tweak: HoP now requires 10 hours as a different Head of Staff
/:cl:

@Autisem
Copy link
Contributor

Autisem commented Aug 1, 2021

TBH too many hours for viro, and detective should still be locked behind hours just because of how powerfull he is, it will only give new player incentives to act a sec officer since they dont know any better

@Rukofamicom
Copy link
Contributor Author

it will only give new player incentives to act a sec officer since they dont know any better

Or perhaps it won't because they won't already be forced into the normal security officer mindset.

@PowerfulBacon
Copy link
Member

I dont think it will change anything with the detective, the only reason they are good for validhunting is because they have basically the most powerful roundstart weapon in all of security. Needing more hours for the more complex roles is good though.

@Rukofamicom
Copy link
Contributor Author

Rukofamicom commented Aug 1, 2021

Bribe someone to change detective from Noire flavored to Sherlock Holmes flavored and we solve that problem pretty handily while keeping a pretty nice and fitting flavor ¯\_(ツ)_/¯

@williamcll
Copy link
Contributor

Honestly no, Det should stay that high because chances are that you might be turned from a private investigator to police inspector when the situation gets bad.

@Rukofamicom
Copy link
Contributor Author

Reverted the detective change to how it was. It now requires three hours as an officer again.

@PowerfulBacon
Copy link
Member

Jesus, 10 hours as cyborg is a lot

@williamcll
Copy link
Contributor

Jesus, 10 hours as cyborg is a lot

that's just seven rounds.

Copy link
Member

@ike709 ike709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virologist is too high

@Rukofamicom
Copy link
Contributor Author

Forgot to keep up with this - it was previously three hours, do you want me to just remove the change entirely?

Still requires medical experience instead of just any three hours.
@ike709 ike709 merged commit 2b90711 into BeeStation:master Aug 14, 2021
PowerfulBacon pushed a commit to PowerfulBacon/BeeStation-Hornet-Bacons-Fork that referenced this pull request Aug 15, 2021
commit 53089f1
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sun Aug 15 07:17:45 2021 +0000

    Automatic changelog compile [ci skip]

commit 547d16c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sun Aug 15 01:49:02 2021 -0500

    Automatic changelog generation for PR BeeStation#5125 [ci skip]

commit 08f3e95
Author: Gallyus <5572280+francinum@users.noreply.github.com>
Date:   Sun Aug 15 01:47:56 2021 -0500

    Hides mentor badge if admin badge shows (BeeStation#5125)

    If a client has an active holder they will not show the mentor badge, as they will by definition be both.

commit 38f72dc
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sun Aug 15 06:23:46 2021 +0000

    Automatic changelog compile [ci skip]

commit 1f94e1b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sun Aug 15 00:44:28 2021 -0500

    Automatic changelog generation for PR BeeStation#5124 [ci skip]

commit 4d20a38
Author: fighterslam <56803762+fighterslam@users.noreply.github.com>
Date:   Sun Aug 15 00:43:15 2021 -0500

    turtle_nerf (BeeStation#5124)

commit 59b3882
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sun Aug 15 00:59:53 2021 +0000

    Automatic changelog compile [ci skip]

commit 0b2cdc6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 20:19:02 2021 +0000

    Automatic changelog compile [ci skip]

commit 71ca420
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:33:20 2021 -0500

    Automatic changelog generation for PR BeeStation#5004 [ci skip]

commit cd27e85
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:32:29 2021 -0500

    Automatic changelog generation for PR BeeStation#5094 [ci skip]

commit 2b90711
Author: Rukofamicom <riskbreakerfamicom2@gmail.com>
Date:   Sat Aug 14 14:32:06 2021 -0500

    Adjusts requirements to unlock jobs (Take two) (BeeStation#5004)

    * Adjusts played requirements

    * Update detective.dm

    * Virologist down to 3h

    Still requires medical experience instead of just any three hours.

commit 5b972fd
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:31:14 2021 -0500

    Automatic changelog generation for PR BeeStation#5105 [ci skip]

commit b98bd64
Author: Vexylius <jacoobs24@gmail.com>
Date:   Sat Aug 14 21:31:08 2021 +0200

    The Incredible Fusion of Medical HUD and Prescription Glasses (BeeStation#5094)

    * 1

    * You're not getting that from beeshop anymore then

    Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>

    * This person has no idea how to use github (+credit to Nae for the sprite)

    Co-Authored-By: Naevii <60577525+Naevii@users.noreply.github.com>

    Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>
    Co-authored-by: Naevii <60577525+Naevii@users.noreply.github.com>

commit 635924c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:30:05 2021 -0500

    Automatic changelog generation for PR BeeStation#5113 [ci skip]

commit 1d81de1
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date:   Sat Aug 14 20:30:04 2021 +0100

    Update beams.dm (BeeStation#5105)

    Co-authored-by: PowerfulBacon <>

commit 3aa5c63
Author: Phil Smith <55861563+TeomanTheGreat@users.noreply.github.com>
Date:   Sat Aug 14 15:28:53 2021 -0400

    TG Stasis Bed Sprite Port (BeeStation#5113)

commit 0dfbafa
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:27:55 2021 -0500

    Automatic changelog generation for PR BeeStation#5115 [ci skip]

commit 80e32a2
Author: James <terra@mcterra.id.au>
Date:   Sun Aug 15 05:26:46 2021 +1000

    allow case-sensitive topic tokens (BeeStation#5115)

    Signed-off-by: Terra <terra@mcterra.id.au>

commit 7a76d38
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 14:17:11 2021 +0000

    Automatic changelog compile [ci skip]

commit b70d954
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 08:46:36 2021 -0500

    Automatic changelog generation for PR BeeStation#5109 [ci skip]

commit 702eee9
Author: Ivniinvi <mattscottheadley@gmail.com>
Date:   Sat Aug 14 06:45:20 2021 -0700

    makes it actually work (BeeStation#5109)

commit bf6e349
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 13:22:00 2021 +0000

    Automatic changelog compile [ci skip]

commit fc3f3b7
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 07:55:37 2021 -0500

    Automatic changelog generation for PR BeeStation#5061 [ci skip]

commit e94277a
Author: ivanmixo <ivanmixo@gmail.com>
Date:   Sat Aug 14 14:54:14 2021 +0200

    Makes the handheld crew pinpointer display who it's pinpointing. (BeeStation#5061)

    * very important

    * oh wow it has subtypes

commit 5e21e05
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 03:04:27 2021 +0000

    Automatic changelog compile [ci skip]

commit 09c586d
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 22:02:33 2021 -0500

    Automatic changelog generation for PR BeeStation#5112 [ci skip]

commit 1e10293
Author: Crossedfall <ping@crossedfall.io>
Date:   Fri Aug 13 22:01:15 2021 -0500

    Game mode config change time (BeeStation#5112)

commit f496a14
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Sat Aug 14 00:56:07 2021 +0000

    Automatic changelog compile [ci skip]

commit 2211083
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 22:05:48 2021 +0000

    Automatic changelog compile [ci skip]

commit 3fe8ce8
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 17:04:18 2021 -0500

    Automatic changelog generation for PR BeeStation#3801 [ci skip]

commit aeca8a4
Author: James <terra@mcterra.id.au>
Date:   Sat Aug 14 08:03:04 2021 +1000

    Topic System Overhaul (BeeStation#3801)

    * start the topic rework

    Signed-off-by: Terra <terra@mcterra.id.au>

    * oh yeah it's all coming together

    Signed-off-by: Terra <terra@mcterra.id.au>

    * noticed a bug

    Signed-off-by: Terra <terra@mcterra.id.au>

    * I forgot my access check

    Signed-off-by: Terra <terra@mcterra.id.au>

    * forgot a param requirement

    Signed-off-by: Terra <terra@mcterra.id.au>

    * another little bug

    Signed-off-by: Terra <terra@mcterra.id.au>

    * remove the insecure arg

    Signed-off-by: Terra <terra@mcterra.id.au>

    * adds cross-server handshakes

    Signed-off-by: Terra <terra@mcterra.id.au>

    * thanks dreamchecker very cool

    * use async proc to avoid 2 seconds additional init

    * fix rate limit and auth bug

    Signed-off-by: Terra <terra@mcterra.id.au>

    * general code improvements (docs, refactor, sec)
    small refactor to some topic queries to modernize them and return json
    adds documentation to the config readme file for topics
    update topic procs to wrap world.export and handle security better

    Signed-off-by: Terra <terra@mcterra.id.au>

    * fix markdown formatting

    Signed-off-by: Terra <terra@mcterra.id.au>

    * editor issue

    Signed-off-by: Terra <terra@mcterra.id.au>

    * censor keys, fix bugs, url encode topic data

    Signed-off-by: Terra <terra@mcterra.id.au>

    * update docs

    Signed-off-by: Terra <terra@mcterra.id.au>

    * include last 4 characters of token

    Signed-off-by: Terra <terra@mcterra.id.au>

commit 12a685d
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 17:23:32 2021 +0000

    Automatic changelog compile [ci skip]

commit f60ffd1
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 11:30:17 2021 -0500

    Automatic changelog generation for PR BeeStation#5084 [ci skip]

commit a7408d4
Author: ImSynthex <81387903+ImSynthex@users.noreply.github.com>
Date:   Fri Aug 13 19:29:03 2021 +0300

    AIs can no longer strip people (BeeStation#5084)

    * AIs can no longer strip people

    * Removed warning for lack of arms

    Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>

    * Removed the other warning too for the sake of consistency

    * A bit janky with the whole harm intent thing, but it works

    * That makes a lot more sense

    Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>

    Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>

commit 99a5ef5
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date:   Fri Aug 13 01:01:47 2021 +0000

    Automatic changelog compile [ci skip]
@Rukofamicom Rukofamicom deleted the requiredhours branch May 31, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants