[PORT] RPD QOL improvements #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
holy shit |
|
Yess, triple layering the space loop will now be nearly not as painful, thank you. |
Crossedfall
previously requested changes
Sep 23, 2022
itsmeow
requested changes
Sep 25, 2022
| * * user - mob that use upgrade on RPD | ||
| */ | ||
| /obj/item/pipe_dispenser/proc/install_upgrade(obj/item/rpd_upgrade/rpd_up, mob/user) | ||
| if(rpd_up.upgrade_flags& upgrade_flags) |
There was a problem hiding this comment.
allows for future upgrades I guess? direct port from /tg/, though it interferes with /obj/item/pipe_dispenser/plumbing so I added an override...
There was a problem hiding this comment.
i meant the syntax around &, I hate it
itsmeow
reviewed
Sep 25, 2022
|
Unaddressed reviews |
|
@itsmeow can you reopen this pr reviews are fully addressed in latest |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
screwed up your master merge, you need to re add the signal signals have different files for stuff now |
mystery3525
requested review from
itsmeow
and removed request for
Crossedfall
itsmeow
reviewed
Oct 27, 2022
|
"Various cumulative fixes" in CL is very unclear |
|
copy pasted from /tg/ |
itsmeow
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports:
various RPD quality life improvements from an entire two years that we missed out on
Why It's Good For The Game
holy shit where have you been all my life
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_vS65yEkOhF.mp4
Changelog
🆑 Skoglol, Dennok, TheChosenEvilOne, Timberpoes, Anturk, DuffCreeper, vincentiusvin, ported by mystery3525
tweak: RPD subcategories and preview icons reorganized.
add: RPD now starts with painting turned off, hitting pipes with build and no paint will target the turf underneath instead. Bye bye turf pixelhunting.
add: Reverse wrench mode upgrade to the RPD. Attention, due to budget cuts, the mode is hard linked to the destroy mode control button.
add: You can now change piping layers on the RPD by scrolling with the mouse wheel.
fix: Various cumulative fixes to RPDs
add: RPD can destroy broken disposal pipe
balance: Securing a disposal pipe over a floor tile with a crowbar in your offhand will remove the floor tile before trying to secure it
/:cl: