TGUI Say #8404

itsmeow · 2023-01-30T11:13:49Z

About The Pull Request

Ports TGUI Say:

TGUI Say: Upgrades chat input with modern features tgstation/tgstation#67116
TGUI Say no longer deletes your currently typed message on history tgstation/tgstation#67971

And some needed pre-req PRs:

Additional changes for BeeStation:

Added explo, uplink, :l, :r, and :h channel handling
Added support for .channel prefixes
Tweaked colors
The entire window is draggable, rather than just parts of it (excluding the textbox, so you can select text)
The border has been tweaked slightly, it is not animated but has a minor gradient on both the top and bottom
Added a border around the text input part of the box
Added LOOC channel
Legacy support pref, with typing indicators and all
Typing ; in Say mode will convert the radio prefix to ;, and removing it will go back to Say.
Shift+TAB and r-clicking the button will go back in channels.
Re-opening the window on a different channel will no longer break the button contents.
Added "show prefix" mode, which treats :s as text in the input box while still updating the color and button.
Pressing Esc on the game window with the say unfocused will exit the say.

SQL Update on merge:

UPDATE SS13_preferences SET preference_value = preference_value | (1<<14) | (1<<15) | (1<<16) | (1<<17) WHERE preference_tag = 2;

Why It's Good For The Game

The "Say" verb is the most used and looks quite awful in my opinion, plus TGUI say is just really cool, and adds some nice features like the thinking indicator and forced-speech (AUGH!!!), as well as more accessibility to new players since the syntax of speech is baked into the say-box.

Testing Photographs and Procedure

Screenshots&Videos

Newest appearance

2023-01-31.03-58-50.mp4

New prefs

Light theme pref

Changelog

🆑
add: Added TGUI-Say (can be disabled in prefs, light theme also in prefs) - Tab to switch channels.
add: Added new TGUI Say keybinds - Y for Radio, U for LOOC (not currently rebindable).
add: Added TGUI input preferences (mostly unused currently).
add: Added glorfing to TGUI-Say - if you get hit hard enough, your message will be cut off with "-OW!!!", "-AUGH!!!", "-GLORF!!" or similar.
admin: Added logging to typing indicators.
add: Added OOC Verb "Refresh TGUI".
tweak: Legacy say hotkey macros (Ctrl+T, Ctrl+O) have been replaced with T and O.
/:cl:

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: iamgoofball <iamgoofball@gmail.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: KubeRoot <6917698+KubeRoot@users.noreply.github.com> Co-authored-by: Kapu1178 <75460809+Kapu1178@users.noreply.github.com> Co-authored-by: Iamgoofball <4081722+Iamgoofball@users.noreply.github.com> Co-authored-by: DomitiusKnack <56321744+DomitiusKnack@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Wallem <66052067+Wallemations@users.noreply.github.com>

adds the ability to realtime inject HTML into TGWindow instances, just as you can create TGWindow instances with inline_html at initialization. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

About The Pull Request adds the Refresh TGUI verb to the debug category OOC category, but it isn't locked behind any permissions. i'd put it in OOC, but.. eeeeeeh? there's not real much use for this verb other for debuggers. i put it in the OOC category Why It's Good For The Game debug purposes mostly not player facing lole

…67971) first commit

PowerfulBacon · 2023-01-31T08:18:19Z

Legendary PR

llol111 · 2023-01-31T18:31:13Z

Holy smokes that looks awfull.
Ive mostly gotten over my "tgui bad on principle" phase, but man that just looks terrible.
We have decent and good looking tgui windows, why's it like this?
cant we just have the normal popup, but made in TGUI?

itsmeow · 2023-01-31T18:50:56Z

We have decent and good looking tgui windows, why's it like this?

Because it's built on IE11 with no modern CSS features, and no polyfills available to regular TGUIs because it needs to not be dependent on 5000 external dependencies.

itsmeow · 2023-01-31T19:17:39Z

cant we just have the normal popup, but made in TGUI?

This is like 5x less functional and more likely to break but certainly possible

llol111 · 2023-01-31T19:25:27Z

I dont know (or care, if im to be honest) about the technical workings in the background.
Im sure you have decent reasons for replacing what we have now, et cetera.
Chat breaking all the time like normal tgui tends to do is a verry valid concern, i suppose.

It would, however, look a lot better.
As is, this looks bad.
Im sure you can justify this being a good thing anyways because >muh functionalities and shit
🤷

itsmeow · 2023-01-31T20:19:37Z

Players will still have the option of old chat, so if you don't like the look you can use that

itsmeow · 2023-03-23T21:44:56Z

I've moved it, is this better?

…ing ;

… the button contents

Eric-01 · 2023-03-25T16:50:10Z

I don't see any difference :/

Absolucy · 2023-03-25T22:49:58Z

Perhaps whispering (# prefix) should appear on the say popup like it does with radio prefixes and such?

PowerfulBacon · 2023-03-28T08:28:21Z

I mean.. I could, but also that wasn't a thing before

The old one didn't need it. This is an entirely new input box though

itsmeow · 2023-03-28T08:42:15Z

I already added the esc macro

PowerfulBacon · 2023-04-03T08:48:38Z

Default 3 talk icon looks pretty bad, I think just remove it and use default0 instead, or a static speech bubble. After that I'm fine with merging this

jlsnow301 and others added 6 commits January 30, 2023 01:44

Port tg/66971

4f4689b

Add replace_html to tgwindows (for real this time) (#67137)

e2de49a

adds the ability to realtime inject HTML into TGWindow instances, just as you can create TGWindow instances with inline_html at initialization. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

Bee-ify TGUI-Say

3fa8a90

TGUI Say no longer deletes your currently typed message on history (#…

2b26ddc

…67971) first commit

github-actions bot added Config Update Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools labels Jan 30, 2023

solid-octo-guacamole bot added the Feature label Jan 30, 2023

itsmeow added 4 commits January 30, 2023 05:30

Glorf 2 electric boogaloo

3b713cd

Fix lint

9056577

OOC and Radio

3ce0acd

Fix lint state

efd9389

PowerfulBacon added the Golden ⭐ For high-effort PRs that make big and good improvements to the game. label Jan 31, 2023

itsmeow added 2 commits January 31, 2023 04:04

Legacy support, prefs, and input box fixes

2b81558

LOOC

7017cee

itsmeow marked this pull request as ready for review January 31, 2023 10:22

itsmeow requested a review from Crossedfall as a code owner January 31, 2023 10:22

solid-octo-guacamole bot added the Administration label Jan 31, 2023

Cleanup light theme, allow text selection, and fix command color

dbe86a2

github-actions bot removed the Administration label Jan 31, 2023

solid-octo-guacamole bot added the Administration label Jan 31, 2023

solid-octo-guacamole bot added the Administration label Mar 23, 2023

Add close with Esc

7d83f6b

github-actions bot removed the Administration label Mar 23, 2023

Move default open position to old input location

7df1536

solid-octo-guacamole bot added the Administration label Mar 23, 2023

Handle . prefixes the same as : prefixes

d7d09b8

github-actions bot removed the Administration label Mar 23, 2023

itsmeow added the Administration label Mar 23, 2023

Fix showRadioPrefix mode not properly updating back to Say when remov…

722dfa1

…ing ;

github-actions bot removed the Administration label Mar 23, 2023

Fix bug where removing prefix with Ctrl+A in show mode will not reset…

ce849c6

… the button contents

Center TGUI Say in the game window

917ab3e

mystery3525 mentioned this pull request Mar 27, 2023

TGUI Botany Seed Extractor window does not autorefresh for certain actions #8772

Open

Improve icon by making default3 a static version of default0

51475e1

github-actions bot added the Administration label Apr 5, 2023

PowerfulBacon approved these changes Apr 5, 2023

View reviewed changes

Crossedfall approved these changes Apr 5, 2023

View reviewed changes

Crossedfall added this pull request to the merge queue Apr 5, 2023

Merged via the queue into BeeStation:master with commit cc88822 Apr 5, 2023

ss13-beebot added a commit that referenced this pull request Apr 5, 2023

Automatic changelog generation for PR #8404 [ci skip]

11e623e

SinguloMirrorbot mentioned this pull request Apr 5, 2023

[MIRROR] TGUI Say SinguloStation13/SinguloStation13#708

Closed

AustationBot mentioned this pull request Apr 5, 2023

[MIRROR] TGUI Say austation/austation#6033

Closed

Bobbanz1 mentioned this pull request Mar 21, 2024

[UPSTREAM] TGUI Say BeeStation/NSV13#2618

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TGUI Say #8404

TGUI Say #8404

itsmeow commented Jan 30, 2023 •

edited

Loading

PowerfulBacon commented Jan 31, 2023

llol111 commented Jan 31, 2023

itsmeow commented Jan 31, 2023

itsmeow commented Jan 31, 2023

llol111 commented Jan 31, 2023

itsmeow commented Jan 31, 2023

itsmeow commented Mar 23, 2023

Eric-01 commented Mar 25, 2023

Absolucy commented Mar 25, 2023 •

edited

Loading

PowerfulBacon commented Mar 28, 2023

itsmeow commented Mar 28, 2023

PowerfulBacon commented Apr 3, 2023

TGUI Say #8404

TGUI Say #8404

Conversation

itsmeow commented Jan 30, 2023 • edited Loading

About The Pull Request

Why It's Good For The Game

Testing Photographs and Procedure

Changelog

PowerfulBacon commented Jan 31, 2023

llol111 commented Jan 31, 2023

itsmeow commented Jan 31, 2023

itsmeow commented Jan 31, 2023

llol111 commented Jan 31, 2023

itsmeow commented Jan 31, 2023

itsmeow commented Mar 23, 2023

Eric-01 commented Mar 25, 2023

Absolucy commented Mar 25, 2023 • edited Loading

PowerfulBacon commented Mar 28, 2023

itsmeow commented Mar 28, 2023

PowerfulBacon commented Apr 3, 2023

itsmeow commented Jan 30, 2023 •

edited

Loading

Absolucy commented Mar 25, 2023 •

edited

Loading