Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Soft'-tracked objectives& Replacement of gimmick objectives #9043

Merged
merged 25 commits into from
Aug 7, 2023

Conversation

PowerfulBacon
Copy link
Member

@PowerfulBacon PowerfulBacon commented May 19, 2023

About The Pull Request

  • Organises the code of objectives a bit better
  • Adds in new open objectives, which are soft-tracked objectives that return a number rather than a greentext/redtext message.
    • Create and detonate explosive device in %location%
    • Sabotage or destroy machines within in %location%
  • Removes gimmick objectives
    • TODO: Remove the config files for this
  • Adds in antag stashes rather than spawning with the items in your backpack (TODO: Test this, I wrote this months ago and can't remember what this does or if it works)
  • Steal objectives will no longer appear if the associated head does not spawn.

Why It's Good For The Game

This PR aims to take the concepts from gimmick PRs of creating more open objectives with more opportunity in their methods of completing, while still having some form of tracking that forces players to perform antagonistic actions. Some of the new objectives added do not have binary greentext/redtext conditions, but a tracked number and a low minimum amount that needs to be achieved.
The main idea behind this PR is to give players a goal that they need to accomplish, give them a reason to take risks while still giving them an open-enough objective that some interesting situations may arise from it.
The types of objectives that I am trying to add have:

  • Clear and obvious antagonistic outcomes, disrupting the crew or station operation in some capacity. Stealth approaches to completing the objectives are perfectly fine, however the outcome of the action should be obvious in some capacity so that the station knows that a threat is present on the station, even if that threat covered their tracks.
  • Are able to be expressed in some numeric form in some capacity, so that a basic measure of how much was performed can be displayed without encouraging the antagonist to stop performing actions once they have completed their objective
  • Are general enough that it would make sense for any member of the crew to be given the objective
  • Generally have good stages of: Preperation, Execution, Consequence

The idea of gimmick objectives (objectives with no greentext/redtext) state, was to have objectives with no greentext/redtext state. This would, in theory, encourage players to complete create gimmicky scenarios with roleplay in mind rather than completion. Unfortunately, in practice this hasn't worked out and gimmick objectives are simply ignored. I believe the main reason for this failure is that removing any kind of measure of success reduces the drive for an individual to take risks.

Will having a number encourage people to take risks? I have no idea, this could completely flop and be removed in a week, but I think a system like this strikes a balance between the freedom to have creative approaches and gimmicky ideas with the need to take risks that may ultimately result in failure. The concept of having objectives with clear consequence for either the crew or the antagonist should also mean these objectives don't face issues where nobody actually knows if anything has happened (which can happen with stealthed steal objectives).

Testing Photographs and Procedure

image
image
image

Changelog

🆑
add: Open objectives, objectives which are not tracked by win/lose but have a numeric outcome.
add: Sabotage machinery objectives
add: Obtain and detonate explosive objective
del: Gimmick objective
refactor: Refactors traitor objective item spawning to start in "stashes" rather than in the backpack.
rebalance: You can no longer get steal objectives for certain items when there is no head to own them.
code: Improves objective code file organisation.
/:cl:

@github-actions github-actions bot added Config Update TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels May 19, 2023
@PowerfulBacon PowerfulBacon changed the title 'Soft'-tracked objective rework & Replacement of gimmick objectives 'Soft'-tracked objectives& Replacement of gimmick objectives May 19, 2023
@EvilDragonfiend
Copy link
Contributor

I think they should be able to check how much they made the goal by checking memory note (or something else).

@CydiaLamiales
Copy link
Contributor

Would having a leaderboard for these be too much?

@Rustyfoxb

This comment was marked as duplicate.

1 similar comment
@Rustyfoxb
Copy link

This seems really fun, you could also add some stuff that tg uses for prog tot like that syndie graffiti.

@PowerfulBacon
Copy link
Member Author

Would having a leaderboard for these be too much?

I want to push people a little bit to continue to antagonise further, but I don't want to push them to the point of making is super competetive as meta strategies may be encouraged to become common.

@PowerfulBacon PowerfulBacon marked this pull request as ready for review May 20, 2023 07:48
@Fronsis
Copy link

Fronsis commented May 20, 2023

Can we get some examples of what could be found on those stashes? And are those only accessible by the traitor?

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label Jun 16, 2023
@itsmeow itsmeow removed the Test Merged This PR is currently in rotation label Jun 21, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label Aug 2, 2023
@@ -238,10 +238,14 @@ GLOBAL_LIST(admin_objective_list) //Prefilled admin assignable objective list
/area/holodeck,
/area/lawoffice,
)
// If our airlock isn't accessible to these accesses, then we won't allow the item to spawn here
var/list/safe_access_list = list(ACCESS_CARGO, ACCESS_MAINT_TUNNELS, ACCESS_MEDICAL, ACCESS_MORGUE, ACCESS_JANITOR, ACCESS_CHAPEL_OFFICE, ACCESS_THEATRE, ACCESS_LAWYER, ACCESS_CONSTRUCTION, ACCESS_MAILSORTING)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel maint airlocks would be too many and hard to find. Theae should be at least hallway maint airlockd?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to pass the area check and the access check, so it can only pick maint airlocks if they are in the whitelisted areas. I believe all maps have labelled maintenance doors, so the name of it will be pretty clear "Chemistry Maintenance Access in chemistry"

@PowerfulBacon
Copy link
Member Author

Pipes shouldnt count as machine break targets

@PowerfulBacon PowerfulBacon added the Testmerge Passed Seemed fine in testmerge label Aug 7, 2023
@itsmeow itsmeow added this pull request to the merge queue Aug 7, 2023
@itsmeow
Copy link
Member

itsmeow commented Aug 7, 2023

merging since it's already TM'd with the config changes for ages

@itsmeow itsmeow removed the Test Merged This PR is currently in rotation label Aug 7, 2023
Merged via the queue into BeeStation:master with commit 29732fe Aug 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance/Rebalance Code Improvement Config Update Feature Refactor Removal Testmerge Passed Seemed fine in testmerge TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants