Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropper QoL #9121

Merged
merged 7 commits into from Jun 8, 2023
Merged

Dropper QoL #9121

merged 7 commits into from Jun 8, 2023

Conversation

JixS4v
Copy link
Contributor

@JixS4v JixS4v commented May 30, 2023

About The Pull Request

Couple of dropper-related QoL fixes. Makes the dropper only have three possible transfer amounts (1u, 2u, 5u) and makes the dropper able to be stored in the botany belt.

Why It's Good For The Game

It's tedious to switch between 1u and 5u transfer in the dropper, furthermore the intermediate transfer amounts are barely used (EDIT: botany needs 2u) and can be replaced by just using the dropper several times.

On the botany belt side, botanists also use droppers and being able to put them in the botany belt is nice.

Testing Photographs and Procedure

Screenshots&Videos

image

4f4768849cf60f6bdc1bfd90c22cb6fe.mp4

Changelog

馃啈
tweak: botany belts are now able to hold droppers
tweak: droppers can now only transfer 1u 2u, or 5u
/:cl:

@JixS4v JixS4v changed the title Dropper tweaks Dropper QoL May 30, 2023
@WrillWasTaken
Copy link
Contributor

What kind of botanist uses droppers? Bottles can do that job much better- the fertilizer bottles from the vendor can all transfer in 1/2/3/4/5u doses.

Also, 2u doses are very important to botany, you should not remove that functionality if you intend on botanists using them.

@JixS4v
Copy link
Contributor Author

JixS4v commented May 30, 2023

What kind of botanist uses droppers? Bottles can do that job much better- the fertilizer bottles from the vendor can all transfer in 1/2/3/4/5u doses.

Also, 2u doses are very important to botany, you should not remove that functionality if you intend on botanists using them.

dunno, was suggested on the forums so I guess some botanists do, and you can always just do 1u twice

@BriggsIDP
Copy link
Contributor

1u twice isn't the same as 2u in botany

@JixS4v
Copy link
Contributor Author

JixS4v commented May 30, 2023

1u twice isn't the same as 2u in botany

ah, i'll amend it then, is there a need for 3u too? It's just 'cause it's annoying to have to go through all of them if you're doing stuff like viro

@BriggsIDP
Copy link
Contributor

BriggsIDP commented May 30, 2023

1u twice isn't the same as 2u in botany

ah, i'll amend it then, is there a need for 3u too? It's just 'cause it's annoying to have to go through all of them if you're doing stuff like viro

I don't believe so. only 1u, 2u, 5u, and 100u is really need

@JixS4v
Copy link
Contributor Author

JixS4v commented May 30, 2023

1u twice isn't the same as 2u in botany

ah, i'll amend it then, is there a need for 3u too? It's just 'cause it's annoying to have to go through all of them if you're doing stuff like viro

I don't believe so. only 1u, 2u, 5u, and 100u is really need

alright thanks for the input!

@WrillWasTaken
Copy link
Contributor

1u twice isn't the same as 2u in botany

ah, i'll amend it then, is there a need for 3u too? It's just 'cause it's annoying to have to go through all of them if you're doing stuff like viro

I don't believe so. only 1u, 2u, 5u, and 100u is really need

50u too.

Copy link
Member

@Penwin0 Penwin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the dropper settings is a bit strange no? I can see them having legitimate use cases

@Nosnek199
Copy link

Dont remove any of the transfer amounts, but make the dropper start on 1u.

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 3, 2023

Changing the dropper settings is a bit strange no? I can see them having legitimate use cases

I'd say there is, but there's a point where you can just use multiple of one as opposed to having to go through all the possible settings to find the one you want. It's a bit of a pet peeve of mine, especially when playing something like viro.

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 3, 2023

PR has been updated with evidence.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jun 8, 2023
Merged via the queue into BeeStation:master with commit 9781860 Jun 8, 2023
8 checks passed
@JixS4v JixS4v deleted the dropper-tweaks branch December 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants