Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 'recipes' variable to 'get_recipes()' proc #9385

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

EvilDragonfiend
Copy link
Member

@EvilDragonfiend EvilDragonfiend commented Jul 12, 2023

About The Pull Request

Changes 'recipes' variable to 'get_recipes()' proc

  • a variable that can possibly be overridable by improper order of Init() proc is not good. (we had a case of durathread uses silk recipe)
  • the variable takes a list, but the variable is a type variable - this is bad.
  • you should be capable of accessing the dedicated list when a material is not initialized yet but created newly.
  • We really shouldn't let this be a variable which can be dynamically changed.

Why It's Good For The Game

better logic

Testing Photographs and Procedure

image## Changelog
馃啈
code: recipes variable in materials is removed. It now uses get_recipes() proc.
/:cl:

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jul 18, 2023
Merged via the queue into BeeStation:master with commit 2506f67 Jul 18, 2023
8 checks passed
@EvilDragonfiend EvilDragonfiend deleted the recipeproc branch July 18, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants