Reworks multitool buffer into a component #9473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
21 tasks
itsmeow
reviewed
Aug 7, 2023
PowerfulBacon
commented
Aug 8, 2023
itsmeow
requested changes
Aug 13, 2023
| REGISTER_BUFFER_HANDLER(/obj/machinery/computer/launchpad) | ||
|
|
||
| DEFINE_BUFFER_HANDLER(/obj/machinery/computer/launchpad) | ||
| if(istype(buffer, /obj/machinery/launchpad)) |
| REGISTER_BUFFER_HANDLER(/obj/machinery/quantumpad) | ||
|
|
||
| DEFINE_BUFFER_HANDLER(/obj/machinery/quantumpad) | ||
| if (panel_open) |
There was a problem hiding this comment.
This is an early return
|
Most of these are just copy and pastes of the existing behaviours to not risk any accidental changes |
itsmeow
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR is a dependency for my upcoming mining refactor.
Reworks the multitool buffer into a component.
This component can be applied to any object.
You can listen for the COMSIG_PARENT_RECIEVE_BUFFER on a target to see when someone is using a buffer object on your object.
You can send COMSIG_ITEM_PUSH_BUFFER to push an item to the buffer.
You can send COMSIG_ITEM_FLUSH_BUFFER to flush the buffer.
Adds some defines for quickly adding in the buffer handlers, cause I am lazy but they can be expanded if requested since they might be considered a bit ugly.
Dependancy of my upcoming lavaland rework.
Why It's Good For The Game
Removes some hard-deletes from multitool buffer.
Testing Photographs and Procedure
Provided below is successful testing documentation for every single object that uses the multitool's buffer feature.
Ore silo + Remote Material Containers
Cloning
Didn't even know this was a think to be honest.
Operating Computer + Stasis Beds
I have since fixed the issue with hitting the computer during linking
Launchpad
Portable Turret Controller + Turret Cover
Telecommunications
Teleporter
Hitting has since been fixed.
Pirate Console
Xenobiology (Monkey Recycler + Camera)
Processing Unit
Runtime has since been fixed.
Stacking Machine
Made this one slightly more intuative by letting it have links on both ways.
Conveyor Belt + Switch
Bluespace Artillery
Why does this even have multitool linking?
Changelog
🆑
code: Refactors multitool buffers to use a component, removing some hard-delete potential.
/:cl: