Fixes Shells are not appropriately handling the presence of powder bags. #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
approved these changes
May 22, 2024
Bokkiewokkie
added
Active Test Merge
Munitions
ss13-beebot
added a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a long standing issue where gunpowder is being packed directly into the shell by powder gates, allowing "pre-loading" to occur where it shouldn't via deconstruction. Feeding the shell now modifies its speed directly before it's sent to the weapon turret.
If you're loading and using the deck turret under normal conditions, nothing changes.
Why It's Good For The Game
Fixes #1385
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_KhkgwjAk7l.mp4
Since gunpowder will be held in the payload gate until used, dismantling it will return your gunpowder without modifying the shell
Changelog
馃啈
fix: Fixed shells are not appropriately handling the presence of powder bags
/:cl: