Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Spinner instead of Progressbar #3527

Closed
TooWaBoo opened this issue Dec 6, 2016 · 6 comments
Closed

Improvement: Spinner instead of Progressbar #3527

TooWaBoo opened this issue Dec 6, 2016 · 6 comments
Labels
type: enhancement Something could be better than it currently is

Comments

@TooWaBoo
Copy link
Contributor

TooWaBoo commented Dec 6, 2016

The progressbar tells me only that RT is working. Most of the time it jumps to the middle, stays awhile and it's finished, but it takes a lot of space.
On the internet, I've found a css-Spinner and adaptet it to RT. Here's a screenshot. I've hijacked some buttons. :-)

unbenannt

It's easy to control them via css. You can change the color, size, size of the dots and speed without any external resource. Control from the application can be done by simply assigning and removing classes to/from the spinner object.

Here is a test theme. The yellow spinner disapears when hovering, the red one starts spinning and the green one runs always. You need Gtk+3.20. Rename the extension .txt to .css.
TooWaBlue-Spinner-GTK3-20_.txt

What do you think?

@Beep6581
Copy link
Owner

Beep6581 commented Dec 6, 2016

There is a dedicated GTK3 spinner: https://developer.gnome.org/gtk3/unstable/GtkSpinner.html
It does not require GTK+ 3.20, it is available from versions earlier than 3.16 (3.16 is the earliest GTK+ version supported by RT).

The decision here is whether the progress bar should get fixed. I would prefer if it did, but issues have been open for years with no progress, so if it won't get fixed, then +1 for spinner, though I think it would be better to use the GTK3 spinner instead of a massive CSS blob.

See #808

@Beep6581 Beep6581 added Component-UI type: enhancement Something could be better than it currently is labels Dec 6, 2016
@TooWaBoo
Copy link
Contributor Author

TooWaBoo commented Dec 6, 2016

Ohps, I forgot the Gtk spinner. If it does the job and looks nice, why not. :-)
Both spinners are save to use. As far as I can see, the css-Spinner has more flexibility.
The one with the least processor load should be the first choice.

@TooWaBoo
Copy link
Contributor Author

TooWaBoo commented Dec 6, 2016

Made some performace tests. The css-Spinner increases pocessing time by around 20% and the CPU load is also 20% higher. That's a lot.
I hope, the Gtk-Spinner is better.

@heckflosse
Copy link
Collaborator

Made some performace tests. The css-Spinner increases pocessing time by around 20% and the CPU load is also 20% higher. That's a lot.

Yes, that's too much. I didn't spend weeks and months to speed up rt to get it eaten up by a gui element...
Hopefully the Gtk-Spinner is better.

@TooWaBoo
Copy link
Contributor Author

TooWaBoo commented Dec 7, 2016

@heckflosse
What are 20%, when you can get such a nice spinner. hahahaha

@RawConvert
Copy link

Better than a hungry spinner, how about simply extending the literals which can appear where "HL Reconstruction" shows, so the user has a feel for what processing is taking place. E.g. add Noise Reduction, Sharpening, Wavelets and any other big hitters. I think this is more useful than a spinner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something could be better than it currently is
Projects
None yet
Development

No branches or pull requests

4 participants