Filmstrip moves active image to the far left

[Thanatomanic]

I think #5125 actually had a side-effect, although @Beep6581 said it didn't. Or maybe there was another commit that changed the filmstrip behavior, but I'm not seeing it. In any case, the issue below is not present in 5.5 (release version) but it is in dev. For what it's worth, I'm using SETM.

What's the issue: whenever I select an image from the filmstrip, it moves the strip so that the selected image is the one on the far left. I would very much prefer the selected image to be (somewhat) in the middle. This is especially annoying when working on a sequence of images where you repeatedly have to scroll to get the earlier images in view.

[TooWaBoo]

This will fix it. Check it out.
Change yellow to blue. 😀

editorpanel.cc

[heckflosse]

@TooWaBoo Your modification breaks this:

    // When passing a photo as an argument to the RawTherapee executable, the user wants
    // this auto-loaded photo's thumbnail to be selected and visible in the Filmstrip.

[heckflosse]

@TooWaBoo scratch my comment from above.

[TooWaBoo]

@TooWaBoo scratch my comment from above.

I will. 😁

[heckflosse]

@TooWaBoo But F3/F4 does not behave as before...

[heckflosse]

@TooWaBoo before modification after F4 the current thumb in filmstrip is always the leftmost (if there are enough thumbs on the right)
after modification sometimes after F4 the current thumb in filmstrip is the rightmost even if there are enough thumbs on the right.

[TooWaBoo]

This should fix the F3/F4 behaviour.

EDIT: Oh sh..., it doesn't. I've to play a bit more.

[TooWaBoo]

Ok, now all changes together.

editorpanel.cc

filebrowser.cc

If you use F3/F4, shift F3/F4 or Left-, Right-button the filmstrip is always alignd left.

[heckflosse]

@TooWaBoo Why don't you post a patch file (or the content of a patch file)? It's as easy as

git diff > toowaboo.patch

Then open in editor and insert it here.

[heckflosse]

@TooWaBoo Honestly, I won't apply screenshot patches anymore. I did it once today (and I didn't it correct, because it was confusing). This led to even more confusion and waste of your and my time.

Please, post a patch or create a pr.

Ingo

[Beep6581]

whenever I select an image from the filmstrip, it moves the strip so that the selected image is the one on the far left. I would very much prefer the selected image to be (somewhat) in the middle.

Agreed, centered would be preferable over left-aligned.

[Beep6581]

We haven't defined what the desired behavior is, so here goes. I like my selected thumbnail centered so that I can see what came before and what's next, but I don't necessarily always want it centered - I would prefer scrolling to not occur if the previous/next thumb is fully visible.

That is exactly what branch centeredthumb does:
https://github.com/Beep6581/RawTherapee/compare/centeredthumb

[Beep6581]

PR #5183 created.

[shastah]

I would prefer scrolling to not occur if the previous/next thumb is fully visible

Does that mean selecting next(prev) image would effectively not scroll filmstrip until image that gets selected is second most-right(left) displayed in the filmstrip, and then every subsequent F4(F3) would scroll it by one?

If my understanding above is correct, is there a way to make it always(*) centered? A setting in preferences perhaps?

(*) Until there are not enough images to scroll filmstrip more left or right, of course

[Beep6581]

Does that mean selecting next(prev) image would effectively not scroll filmstrip until image that gets selected is second most-right(left) displayed in the filmstrip, and then every subsequent F4(F3) would scroll it by one?

The first part is correct, the second is not. Once selection gets to the second-most thumb from the right, and you switch to the next image, that image's thumb will now be centered. In other words, it doesn't scroll unless necessary, and when it is necessary then it centers the thumb.

is there a way to make it always(*) centered? A setting in preferences perhaps?

Yes, that's even simpler to code, but could be annoying when you want to keep everything as it is and just switch to the next image.

A setting in preferences perhaps?

I'd rather not add bloat.

Here's a video of the behavior in branch centeredthumb:
https://filebin.net/ti5tj508h8q8cmhe/video-2019-02-24_12.07.46.mp4?t=65ddos94

[Beep6581]

Closing as fixed.