-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single tiled deflate compressed DNGs not decoded properly #6575
Comments
The old code looks messed up. Fixes Beep6581#6575
The old code looks messed up, but I'm not sure... Fixes Beep6581#6575
The old code looks messed up, but I'm not sure... Fixes Beep6581#6575
Which cameras and software produce deflate-compressed DNGs? |
I haven't come across any deflate compressed DNGs in the wild. This issue was just something I noticed when playing with the different options in the DNG specification. |
For example HDRMerge produces 16/24/32-bit float deflate compressed DNGs. Not sure what it does re striping/tiling...
There are HDRMerge samples on https://raw.pixls.us/ |
Short description
I just tried opening a DNG using deflate compression with only one tile. If fails miserably since
tile_length
is set to INT_MAX before reaching this if statement:RawTherapee/rtengine/dcraw.cc
Line 10906 in 2ce5b82
Steps to reproduce
tile_offset
,tile_length
, andtile_width
are messed up)This is were things get messed up:
RawTherapee/rtengine/dcraw.cc
Lines 6551 to 6554 in 2ce5b82
Followed by:
RawTherapee/rtengine/dcraw.cc
Lines 7065 to 7066 in 2ce5b82
Expected behavior
The attached image should be decoded properly.
Additional information
Version: 5.8-3139-g2ce5b827c
Branch: dev
Commit: 2ce5b82
Commit date: 2022-08-30
Compiler: cc 10.2.1
Processor: x86_64
System: Linux
Bit depth: 64 bits
Gtkmm: V3.24.2
Lensfun: V0.3.2.0
Build type: release
Build flags: -std=c++11 -march=native -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags: -march=native
OpenMP support: ON
MMAP support: ON
Build OS: Linux 5.10.0-16-amd64 x86_64
Build date: Mon, 05 Sep 2022 09:39:15 +0000 UTC
Build epoch: 1662370755
Build UUID:
The text was updated successfully, but these errors were encountered: