Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locallab: speedup for blur, also some cleanups #5279

Merged
merged 2 commits into from Apr 12, 2019

Conversation

heckflosse
Copy link
Collaborator

No description provided.

@heckflosse heckflosse requested a review from Desmis April 12, 2019 13:19
@heckflosse
Copy link
Collaborator Author

Processing times with this pp3 on a D850 NEF
Nikon - D850 - 14bit compressed (Lossless) (3_2).NEF.pp3.txt

                               before              after
open                            50 ms              40 ms
zoom in to 100%(z)            2390 ms              70 ms
open detail window            2490 ms               3 ms
full processing               1830 ms            1530 ms

@Desmis
Copy link
Collaborator

Desmis commented Apr 12, 2019

@heckflosse
I just tested

Same sppedup as others speedup, same improvments as you

No differences visble on TIF

Very very very small diffreences with layers diffrences

Good job, as usual :)

jacques

@heckflosse heckflosse added tool: local adjustments scope: performance Performance issues and improvements labels Apr 12, 2019
@heckflosse
Copy link
Collaborator Author

@Desmis Jacques, thanks for testing 👍

@heckflosse heckflosse merged commit dc1f6f6 into newlocallab Apr 12, 2019
@heckflosse heckflosse deleted the newlocallab-speedup4 branch April 12, 2019 15:18
@Desmis
Copy link
Collaborator

Desmis commented Apr 15, 2019

@heckflosse
Hello Ingo
I found a bug with "Blur"

When the spot is completely outside the preview (zoom...), the system crash.
Could you have a look :)

Thank you

@heckflosse
Copy link
Collaborator Author

@Desmis I will have a look

@heckflosse
Copy link
Collaborator Author

@Desmis Jacques, can I push a fix?

@Desmis
Copy link
Collaborator

Desmis commented Apr 15, 2019 via email

@heckflosse
Copy link
Collaborator Author

pushed

@Desmis
Copy link
Collaborator

Desmis commented Apr 15, 2019

@heckflosse
Ingo
Confirm fixed, thank you :)

jacques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: performance Performance issues and improvements tool: local adjustments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants