Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere in the past we have adopted functions from SLEEF, see https://github.com/shibatch/sleef. However, I noticed recently that we use a very old version, probably 2.90 dated April 2016. In the meanwhile several SLEEF functions have had improvements (probably to do with either speed or accuracy), but those were never ported to RT.
The latest release in the 2.# branch is 2.121 (dated Jan 30, 2017), and then a new major branch with breaking changes was started and continued. The latest release in the 3.# branch is 3.5.1 (dated Sep 15, 2020).
Unless somebody (hopefully @heckflosse or @Floessie) tells me it is unnecessary, I would like to continue to update our SLEEF functions to their current optimal forms. First I will bring them up to date with the 2.121 version and potentially continue making changes to adopt the 3.5.1 version.
How does that sound?
So far I have made a round of updates for
sleef.h
only which you can give a testrun. It compiles and links, so I guess I haven't already broken something. I haven't touched the SSE2 functions.