Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local adjustements - Color appearance Cam16 and Log encoding - Harmonize Abstract Profile #6861

Closed
wants to merge 321 commits into from

Conversation

Desmis
Copy link
Collaborator

@Desmis Desmis commented Oct 2, 2023

I had some problems with the lacam16 branch merging with dev, which led me to change the pull request

I put the previous PR in draft mode.

The content is the same

@Desmis
Copy link
Collaborator Author

Desmis commented Mar 26, 2024

@Lawrence37

I come to you because I think, unless there is an error on my part, or my configuration (which is nothing special), that there is a malfunction in the last "merge" #6769 - under Windows (I am with Windows 11). But maybe it's something else ?
I tried it - without realizing it - but only with one screen because I was on the move (I have a laptop). Everything seemed to be working normally.

Yesterday morning I did a merge with "dev" and my 2 screen configuration. As soon as I started it I saw something wrong.
This is why I created another PR "lacam16n2" without this merge.

The problem also appears in my latest "Dev" version and is therefore not linked (I think) to lacam16
What is happening ? You know I'm not at all an expert on this sort of thing:

  • in Preferences: Editor Layout , only 2 selections possibles - Single Editor tabs Mode, Vertical Tabs - Multiple editor Tabs mode. The other choice are selected the first time, then ignored.
  • Position of curve copy & paste buttons : ignored

it seems that the 'option' file is corrupted and the only solution, when I take a version that works correctly is to delete the 'options' file
When you activate "2 screen" mode : Multiple editor Tabs ..own Window mode"... The image is curious, superimposing in the preview, that of the file browser, vertically on the left.
I attach a screenshot
The file browser with Multiple editor Tabs ..own Window mode"..
image

The preview (2 snd screen)
image

I know you don't have Windows natively. If you tell me what to look at, retouch, no problem.
but I don't think I'm the only one??

Thank you very much

Jacques

@Desmis
Copy link
Collaborator Author

Desmis commented Mar 29, 2024

@Lawrence37 @sgotti

I think you fixed the bug...
All seems to work fine

Thank you very much

Jacques

@Desmis
Copy link
Collaborator Author

Desmis commented Apr 8, 2024

@Lawrence37
The numerous tests carried out on the challenge and before the challenge, revealed several bugs (7 I think). The system seems stable now.
https://discuss.pixls.us/t/rawtherapee-processing-challenge/42647/78

Asking you for a review seems difficult, as the code has undergone some major changes over the past 1 year.
I think this challenge is a good way of validating the code itself.

Of course I don't forbid you to "look" and make a review. I propose a merge early next week (within 7 to 8 days).

Thank you very much

Jacques

@Lawrence37
Copy link
Collaborator

It is reassuring that several people have tried it. I would like to try it myself, but I have been busier than usual and there are also a few other open PRs to look at.

@Desmis Desmis removed this from the v5.11 milestone Apr 8, 2024
@Desmis
Copy link
Collaborator Author

Desmis commented Apr 8, 2024

@Lawrence37

With all branches open... I made a mistake, the branch to evaluate and merge is lacam16n2

Sorry

Jacques

@Desmis Desmis marked this pull request as draft April 8, 2024 06:09
@Desmis Desmis closed this Apr 15, 2024
@Desmis Desmis deleted the lacam16n branch April 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants