Local adjustments tools used globally - Laspotmain

[Desmis]

A first try... It's 90% a GUI problem.

In this solution I added an extra choice "main".

It sets all the settings as "full image", but systematically sets "scope" to 100, all manipulations on deltaE are canceled as well as all those on transitions.
The corresponding settings are hidden.

Of course you can duplicate, use masks, use if necessary "exclude", etc.

Jacques

[Desmis]

I added (not without difficulty...I'm a poor computer scientist, maybe there is a simpler method ?) the possibility in "Preferences" to choose the Spot startup method (Normal spot, Excluding spot, Full image, Global).

• "Define Spot method for Local Adjustments"

Note that in the new "Global" (main) option, the center of the RT-spot remains visible and movable. This is particularly useful if you want to make "Graduated Filters"

Jacques

[waynesutton50]

This certainly does a good job of de-cluttering the interface. I haven't tested it in any detail but on the face of it, everything seems to work as it should. I did find one anomaly though that can be reproduced as follows:
Select Full-image and a particular tool and then activate the Preview DeltaE button. If you then switch to Global instead of Full-image without de-activating the Preview deltaE first, the deltaE indication will remain.

For local-adjustment spots (Normal, Excluding & Full-image) there are a couple of things which might help also:

1. Move the "Show additional settings" checkbox down after the spot set-up . To me this would be more logical and it would also mean that you don't have to scroll right to the top of the menu if you want to add additional settings when a particular tool has been opened.
2. Remove the common Scope (color tools) slider and equip all tools with their own Scope slider. Having a common slider for some tools only is not only confusing but it also means you have to scroll up to adjust it when using several tools on the same spot. A deltaE preview button on a per-tool basis would also be a help and would avoid the confusion that sometimes arises because someone has pressed the deltaE preview button not realising that a tool has to be added before it does anything.

[Lawrence37]

So far in my tests, it looks good. There is one minor issue with the Preview ΔE toggle buttons. If I enable one button, then enable another one, the first button is still toggled. That means this is possible:

1. Enable Preview ΔE in tool 1. It shows the ΔE. Good.
2. Enable Preview ΔE in tool 2. It shows the ΔE for tool 2. Good. The Preview ΔE for tool 1 is still enabled. Strange.
3. Disable Preview ΔE in tool 2. The ΔE turns off. Bad, because the Preview ΔE for tool 1 is still enabled.
4. Disable Preview ΔE in tool 1. The ΔE is still off. Good.
5. Enable Preview ΔE in tool 1. It shows the ΔE. Good, but I had to press the button twice for it to show the ΔE.

Ideally, enabling a Preview ΔE button turns off the previously active one, if it exists.

[Desmis]

@Lawrence37

Thank you very much for this review :)

This behavior (bad) is known and documented here.
https://rawpedia.rawtherapee.com/Local_Adjustments#Previewing_the_adjustment_area_using_deltaE_(%CE%94E)

I don't think there is a solution with the "button". But using the same command in "Mask and Modifications" everything works correctly (at least I hope).

This entire code was designed, in principle, by Pierre @Pandagrapher , whom I thank infinitely. What remains now, and this is not an easy task, is to create a more intuitive GUI interface for “Settings”.

Thank you again

Jacques

[Lawrence37]

I read the documentation you linked, but I can't find the section that talks about the issue I described. I see it says there is a limitation when using the button in Settings, but the issue I see is with the buttons in the individual tools. Can you copy and paste the part of the documentation here?

[Desmis]

@Lawrence37

Here the copy of this part of Rawpedia.

But I don't really understand what you mean, by "buttons in the individual tools" (my english is bad!).

Perhaps the documentation is not precise enough or not up to date (from this PR obviously), but I added these buttons in some (not all) modules to avoid going back and forth with Settings....But their operation is identical to that of Settings, we can only use one at a time. Otherwise to use several and reset, you must use "Mask and Modifications" => Preview deltaE, which is not accessible in "Basic" mode

=====
Previewing the adjustment area using deltaE (ΔE)
You can preview the areas of the image that will be affected by any changes. The preview does not show the changes themselves or the transitions, but allows you to set the scope of any adjustments.

There are two possibilities:

• Use the Preview ΔE button located in Settings. This will only work properly if you have activated one (and only one) of the color tools in "Add tool to current spot" menu.
• Use the Preview ΔE option in the "Mask and modifications" menu associated with a particular tool (standard and advanced modes only). In this case the GUI takes into account any adjustments made with the tool and works regardless of the number of activated tools.
  Jacques

[Desmis]

@Lawrence37
The modules which are not equipped with it correspond, at the LA level, to different processing algorithms for the management of the deltaE

• Contrast by detail levels
• Sharpening
• Blur grain & denoise
• Soft light & Original Retinex

Jacques

[Lawrence37]

Now there are multiple Preview ΔE buttons, and you write that only one can be used at a time. That makes sense to me. However, if you click on two of the buttons, you can see that both are pressed. I think if you click on the second button, the first button should be deactivated automatically.

[Desmis]

@Lawrence37
I think you can't have everything :)

The operation of the GUI is complex when you have several tools in the same Spot and/or several Spots. And I don't know how to do. Pierre made a system work with "Mask & modifications", but this button added "for convenience" always had this restriction. It seems to me that this should be specified in the documentation.
I added these buttons, this avoids going back and forth, but their management remains the same.

Making Scope work for all tools - with a separate slider, whereas previously the "color" tools were grouped together is a notable plus. But the management of the Preview remains with this handicap

Thank you

[Desmis]

@Lawrence37
But of course if someone: you, Pierre @Pandagrapher or another volunteer tries to improve I only see advantages.

Jacques

[Desmis]

@Lawrence37
I know that there is a small problem with "Preview deltaE", but I think that to my knowledge there are no solutions, without a complete overhaul of the GUI. This problem seems secondary to me compared to the interest of Global mode.

I propose to merge in the coming days, if no one objects.

Jacques

[Lawrence37]

There is a simple solution. Allow me some time to fix it. I am sure someone will bring this up as a usability problem if it is not fixed.

[Desmis]

@Lawrence37

No problem, I wait :)

Jacques

[Lawrence37]

@Desmis I finally had enough time to finish the button toggling code. I think this is good now.

[Desmis]

@Lawrence37 @waynesutton50

I just compiled and tried. Everything seems to work fine.

Many thanks. This is the kind of change I don't know how to make.
I'm going to try it every which way, but I think it will confirm the correct behavior.

If nothing stands in the way, we'll be able to merge within the week.

Thank you again

Jacques

[Lawrence37]

There's a duplicate line here.

[Desmis]

OK, I will change in next commit