-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dcraw: add Panasonic DC-GH6 #7020
Conversation
rtengine/camconst.json
Outdated
"ranges": { | ||
"white": 65535 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decoder already has the white level for this camera.
white levels: R:65535 G1:65535 B:65535 G2:65535 (provided by dcraw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
If useful this isn't directly provided by any metadata but calculated from tiff_bps (16 in this case):
Line 10720 in 5a25619
maximum = ((uint64_t)1 << tiff_bps) - 1; // use uint64_t to avoid overflow if tiff_bps == 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the edit to my comment in the other Panasonic camconst PR, Libraw has the color matrix and white level. We should consider copying the new Libraw constants for all cameras into dcraw.cc.
https://github.com/LibRaw/LibRaw/blob/158e635e5e80a95dfa402b0a79a7167922c1d4ec/src/tables/colordata.cpp#L1387-L1388
@Lawrence37 Updated the PR to update the dcraw adobe_coeffs table instead of a camconst entry. |
dcraw: add Panasonic DC-GH6 to adobe_coeffs
Depends on v8 decoder provided by #7018
Tested images