Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciecam - Change management viewing temperature and tint #7055 #7058

Merged
merged 3 commits into from May 1, 2024
Merged

Conversation

Desmis
Copy link
Collaborator

@Desmis Desmis commented Apr 25, 2024

See issue #7055

@kaesa
Copy link

kaesa commented Apr 30, 2024

Would this kind of comparison in the ColorAppearance::wbCamChanged function be considered unreliable or otherwise undesirable? This didn't spam the history values in my quick test and ticking the checkbox both moved the slider and changed the applied value. It also seemed to fix the issue with Automatic Symmetric mode, where the applied value was forced, but moving the slider printed wrong values to the history.

[this, temp, tin, autotemp]() -> bool
        {
            if (temp != tempout->getValue()) {
                disableListener();
                tempout->setValue(temp);
                enableListener();
                listener->panelChanged (EvCATtempout, tempout->getTextValue());
            }
            if (tin != greenout->getValue()) {
                disableListener();
                greenout->setValue(tin);
                enableListener();
                listener->panelChanged (EvCATgreenout, greenout->getTextValue());
            }
            /*
            disableListener();
            tempout->setValue(temp);
            greenout->setValue(tin);
            enableListener();

            if(!autotemp) {
                listener->panelChanged (EvCATgreenout, "");//greenout->getTextValue());
                listener->panelChanged (EvCATtempout, "");//tempout->getTextValue());
            }*/

            return false;
        }

@Desmis
Copy link
Collaborator Author

Desmis commented Apr 30, 2024

@kaesa

it works, it's another way - a little simpler - to achieve the result. I'm going to change it.
But, for the record, this "wbCamChanged" function, I have already disabled/enabled it several times.

In any case, thank you for this positive contribution.

Jacques

@Desmis Desmis merged commit a53ddf4 into dev May 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants