Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scaffolding): compiling failed with semicolons #9

Merged
merged 2 commits into from May 31, 2019
Merged

fix(scaffolding): compiling failed with semicolons #9

merged 2 commits into from May 31, 2019

Conversation

diyews
Copy link
Contributor

@diyews diyews commented May 31, 2019

Hello, when I am using the new angular-cli(v8.0.1) to create a new project, import frow library then it shows me the error below. My sass version is 1.19.0 .
So I am trying to fix this. BTW, a code refactor commit too. Thanks for your time.

         Semicolons aren't allowed in the indented syntax.
      │
 22   │     display: inline;
      │                    ^
      │

@codysherman
Copy link
Member

Thanks for the PR! Reviewing...

@codysherman codysherman merged commit 550c0e5 into Beg-in:master May 31, 2019
@codysherman
Copy link
Member

codysherman commented May 31, 2019

Hey @diyews thanks so much for this Pull Request! I was able to merge it in right away, and have already released the update to npm (version is 3.1.3)! I also gave you credit in the release notes.

Please let me know if you have further issues, and feel free to continue to contribute to Frow! Thanks so much for the help!

@diyews
Copy link
Contributor Author

diyews commented Jun 1, 2019

Thanks! It works perfect now. Frow is great, it's my pleasure to make it better. Feel happy if there is anything else I could help~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants