#26 Forced custom context class #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,11 @@ class ContextProcessor extends BaseProcessor | |||
| */ | |||
| protected function getContextClass(ContainerInterface $container, InputInterface $input) | |||
| { | |||
| $contextClass = $container->getParameter('behat.context.class'); | |||
| if ('FeatureContext' !== $contextClass) { | |||
There was a problem hiding this comment.
It seems wrong. It should be null !== check. And you simply need to set behat.context.class to null in behat_bundle.xml
There was a problem hiding this comment.
In this case possible variant when "getContextClass" method returns null. Is it applicable?
| @@ -64,6 +69,6 @@ class ContextProcessor extends BaseProcessor | |||
| return $namespacedContext; | |||
| } | |||
|
|
|||
| return $container->getParameter('behat.context.class'); | |||
| return $contextClass; | |||
There was a problem hiding this comment.
Throw \RuntimeException here about "can't determine context class"
| @@ -3,6 +3,7 @@ | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
| <parameters> | |||
| <parameter key="behat.context.class">null</parameter> | |||
There was a problem hiding this comment.
Just:
<parameter key="behat.context.class"></parameter>and i'll merge
There was a problem hiding this comment.
Are you sure?, at other configs null passed explicit.
https://github.com/Behat/Behat/blob/master/src/Behat/Behat/DependencyInjection/config/behat.xml#L6
everzet
added a commit
that referenced
this pull request
Nov 15, 2011
#26 Forced custom context class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.