Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw exceptions on empty feature files #47

Closed
everzet opened this issue Jan 28, 2013 · 4 comments
Closed

Do not throw exceptions on empty feature files #47

everzet opened this issue Jan 28, 2013 · 4 comments

Comments

@everzet
Copy link
Member

everzet commented Jan 28, 2013

Behat/Behat#219 (comment)
@MPV
Copy link

MPV commented Apr 29, 2013

+1

@stof stof mentioned this issue Jan 4, 2014
Closed
@stof
Copy link
Member

stof commented Jan 5, 2014

@everzet what should we return in such case ? Should we return an empty FeatureNode ? I don't see any other way to respect the API (it cannot return null)

@stof
Copy link
Member

stof commented Jan 5, 2014

hmm, actually no. the Parser returns FeatureNode|null

@stof
Copy link
Member

stof commented Jan 5, 2014

Actually, the latest version of the library already supports it. It is covered by tests

@stof stof closed this as completed Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@everzet @MPV @stof