New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Symfony 4 #126
Conversation
99e9f65
to
977295e
Compare
I'm available to help on this subject as this PR is the latest requirement to bump to symfony 4 on our side ^^ |
I believe the last PR is the one on minkphp/MinkBrowserKitDriver#123 |
- php: 7.1 | ||
env: SYMFONY_VERSION='3.0.*' | ||
env: SYMFONY_VERSION='4.0.x-dev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change this to 4.0.*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not here, these are the allowed failures
.travis.yml
Outdated
- php: 7.1 | ||
env: DEPS=dev SYMFONY_VERSION='3.4.*' | ||
- php: 7.1 | ||
env: DEVS=dev SYMFONY_VERSION='4.0.x-dev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change this to 4.0.*?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
Merged and relased 2.1.3 🎉 |
@sroze You rock! 💪 |
Use this opportunity to also drop Symfony 2.3, replace 3.0 with 3.3 in Travis.
Depends on: