Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 4 #126

Merged
merged 13 commits into from Dec 13, 2017
Merged

Support for Symfony 4 #126

merged 13 commits into from Dec 13, 2017

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Oct 23, 2017

@tyx
Copy link

tyx commented Nov 27, 2017

I'm available to help on this subject as this PR is the latest requirement to bump to symfony 4 on our side ^^

@sroze
Copy link
Contributor Author

sroze commented Nov 27, 2017

I believe the last PR is the one on minkphp/MinkBrowserKitDriver#123

- php: 7.1
env: SYMFONY_VERSION='3.0.*'
env: SYMFONY_VERSION='4.0.x-dev'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to 4.0.*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, these are the allowed failures

.travis.yml Outdated
- php: 7.1
env: DEPS=dev SYMFONY_VERSION='3.4.*'
- php: 7.1
env: DEVS=dev SYMFONY_VERSION='4.0.x-dev'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to 4.0.*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@sroze sroze merged commit 58ff140 into master Dec 13, 2017
@sroze sroze deleted the sf4 branch December 13, 2017 15:41
@sroze
Copy link
Contributor Author

sroze commented Dec 13, 2017

Merged and relased 2.1.3 🎉

@ruudk
Copy link

ruudk commented Dec 13, 2017

@sroze You rock! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants