Add ENABLE_COROUTINES CMake option #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will accept if you set the option On by default |
|
@facontidavide the default is OFF because the variable is in charge of disabling the coroutines (i.e. ON would mean the coroutines would be disabled). Would you like me to swap the flag convention so that it enables coroutines? |
|
Yes, don't like double negations ;) |
|
@facontidavide fair enough. Original PR was a bit lazy to use most of the existing CMakeLists.txt layout. I have updated the convention. |
fultoncjb
changed the title
|
Thanks a lot |
|
https://github.com/BehaviorTree/BehaviorTree.CPP/runs/4923912165?check_suite_focus=true Can you have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some organizations, particularly ones with strict threading models, may want to disable coroutines from the build, even if a sufficient Boost version is present on their system. This PR just exposes a new DISABLE_COROUTINES CMake option so that the user may forcefully disable them.