Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Map and Navigation component enums #16

Merged
merged 8 commits into from Aug 18, 2020
Merged

Add Map and Navigation component enums #16

merged 8 commits into from Aug 18, 2020

Conversation

BeksOmega
Copy link
Owner

@BeksOmega BeksOmega commented Jul 23, 2020 •
edited

Description

Depends on #6

Added Units (Metric, Imperial), MapType (Road, Aerial, Terrain) and TransportMethod (Foot, Car, Bicycle, Wheelchair) definitions.

Added these to the Map and Navigation components.

Testing

  • Tested that all helper blocks showed up properly in the drawer.
  • Tested that all values could be set using helper blocks and concrete blocks.

Recommended Method for Review

Commit-Wise

@BeksOmega BeksOmega changed the title Soc/map stuff Add Map and Navigation component enums Jul 23, 2020
@BeksOmega BeksOmega changed the base branch from soc/drawer to soc/upgraders July 28, 2020 17:02
@BeksOmega BeksOmega force-pushed the soc/upgraders branch 3 times, most recently from 52dd1cd to d049c2a Compare August 12, 2020 16:16
@BeksOmega BeksOmega changed the base branch from soc/upgraders to soc/develop August 12, 2020 16:30
ewpatton
ewpatton requested changes Aug 16, 2020
View reviewed changes
Copy link
Collaborator

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to address.

appinventor/blocklyeditor/src/versioning.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/versioning.js Outdated Show resolved Hide resolved
appinventor/components/src/com/google/appinventor/components/common/MapType.java Show resolved Hide resolved
appinventor/components/src/com/google/appinventor/components/common/Units.java Outdated Show resolved Hide resolved
@BeksOmega BeksOmega mentioned this pull request Aug 16, 2020
Open
ewpatton
ewpatton approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeksOmega BeksOmega merged commit 238c733 into soc/develop Aug 18, 2020
BeksOmega pushed a commit that referenced this pull request Nov 1, 2023
@mark-friedman
Include lexical variable plugin code (#16)
633abbb 
* Change Block.blockDB_ to Block.blockDB

* Include lexical variable plugin code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewpatton ewpatton ewpatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BeksOmega @ewpatton