Add Lego NXT Dropdown Blocks #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
soc/upgraders
branch
from
5f178db
to
2397937
Compare
BeksOmega
force-pushed
the
soc/upgraders
branch
2 times, most recently
from
52dd1cd
to
d049c2a
Compare
BeksOmega
force-pushed
the
soc/nxt-enums
branch
from
8a3ef1b
to
1d9c30e
Compare
ewpatton
requested changes
Aug 25, 2020
...entor/appengine/src/com/google/appinventor/client/youngandroid/YoungAndroidFormUpgrader.java
Outdated
Show resolved
Hide resolved
...entor/appengine/src/com/google/appinventor/client/youngandroid/YoungAndroidFormUpgrader.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/common/NxtMailbox.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/common/NxtMotorMode.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/NxtDirectCommands.java
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/NxtDirectCommands.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/NxtDirectCommands.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/NxtDirectCommands.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/NxtDirectCommands.java
Outdated
Show resolved
Hide resolved
ewpatton
requested changes
Aug 31, 2020
appinventor/components/src/com/google/appinventor/components/common/NxtMailbox.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/common/NxtMotorMode.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/common/NxtRegulationMode.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/common/NxtRunState.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/util/ErrorMessages.java
Outdated
Show resolved
Hide resolved
BeksOmega
force-pushed
the
soc/nxt-enums
branch
from
7a8534f
to
59609dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #8
Adds lots and lots of dropdown blocks to go with the NxtDirectCommands component. Hopefully this will make it semi usable without having to dig up Lego documentation!
Testing
I tested that blocks get properly upgraded using this project: test11.zip
I was not able to test functionality as I don't own an Nxt 😢
Recommended Method for Review
Commit-wise
Also note this PR looks longer than it is. There were some functions that had a lot of parameters, and I decided to sprend them out 1 param per line for readability.