-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switchable Dark Theme - Attempt 2 - Ongoing #726
Open
Laimonade
wants to merge
15
commits into
BelaPlatform:dev
Choose a base branch
from
Laimonade:dev-dark-theme-leo
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread. Send 'auto' to automatically discover new MIDI devices.
6379d53
to
8502912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! :) Here's my second attempt at implementing a theme switching for Bela's IDE.
The approach here is to use SCSS
@mixin
and a map, allowing to define a colour variables for each of the themes.The main logic and colour variable definitions are located in
IDE/frontend-dev/scss/base.scss
.The idea is that we (only) move every specific element properties affected by the theme switching into a theme switching function (
themify
), performing the colour switch only on the relevant properties.In each scss file containing elements which need to change colour, the relevant properties for the element is being moved at the top of the file inside of the themify function.
While this may not the cleanest of look, it allows 2 things:
There's still a bit of work to get this polished, but sharing now if people wants to start testing/using it before.
ps: You can discard the commit history before Feb 14, 2024. They shouldn't be in the commit history but not sure how to safely rewrite the history.