-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): add data-testid rule #56
Conversation
fbf9724
to
d3d38b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I left some comments/questions to clarify a couple of things first.
Thanks for the review! I made the requested changes here: c7aa60f Let me know what ya'll think, happy to continue iterating on it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for reviewing this so late! Thanks for this PR, this looks really nice. Just one thing: what if I use a custom test id attr? For example, in one of the projects I work this is customized to data-test-id
. Would be possible to update the rule to have the option to customize the attr? Thanks!!
@Belco90 no problem!. That's a great call, I totally forgot that was configurable now in RTL. I'll add that as a configuration option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This looks good to go 🚀
Forgot to update the docs, that commit is coming in 2 mins! |
Also, the test coverage should be increased: https://travis-ci.org/Belco90/eslint-plugin-testing-library/jobs/636430039 I don't know why this wasn't blocking the PR, need to check it in a different ticket. |
Coverage and docs updated, let me know if there's anything else I can help with! |
Brilliant, merging now for real. |
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @tknickman for code, doc and test |
I've put up a pull request to add @tknickman! 🎉 |
Thanks! |
Here is the PR for the
data-testid
rule. Let me know what you think! Happy to make any adjustments necessary.Fixes #55