-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make call to action button component #464
Conversation
Sure, I can do that.
Do we actually need to stick to fuchsia as text color? It would be probably better to leave the background in fuchsia and the text color in white, so it improves the contrast and we don't need so lighter colors for hovering/clicking. Something closer to the Toggle Dark button, but following your design. |
I want our CTA button to match our mascot's main color, so that's why I'm using Fuchsia as text color. The idea is that our site "feels" fuchsia, because that's the octopus main body color. 😉 I don't like having white text on a colored background, it looks ugly, and it has less contrast than having a dark colored text on a light background. |
Fair enough! I've checked your changes, it looks better. I'll apply the shadow improvements later. |
Changes
CTAButton
componentContext
Closes #269
Not sure if the hover and active status look great so lighter?
CleanShot.2021-10-19.at.20.04.42.mp4