Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make call to action button component #464

Merged
merged 8 commits into from
Oct 22, 2021
Merged

Make call to action button component #464

merged 8 commits into from
Oct 22, 2021

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Oct 19, 2021

Changes

  • Implements new CTAButton component
  • Uses new component homepage

Context

Closes #269

Not sure if the hover and active status look great so lighter?

sizzy-photo-studio-2021-10-19T180302 755Z

CleanShot.2021-10-19.at.20.04.42.mp4

@Belco90 Belco90 self-assigned this Oct 19, 2021
src/components/CTAButton.tsx Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose marked this pull request as draft October 21, 2021 08:28
@Belco90
Copy link
Member Author

Belco90 commented Oct 21, 2021

Maybe we can do something with the box shadow around the button when it's clicked/active? That would retain the shape of the button, without losing text contrast.

Sure, I can do that.

The problem with having fuchsia as a text color, is that it needs to be a really dark fuchsia on a white background, so I cannot do anything with the call to action text itself, like lighten it, because that would lead to unreadable contrast.

Do we actually need to stick to fuchsia as text color? It would be probably better to leave the background in fuchsia and the text color in white, so it improves the contrast and we don't need so lighter colors for hovering/clicking. Something closer to the Toggle Dark button, but following your design.

@HonkingGoose
Copy link
Collaborator

Do we actually need to stick to fuchsia as text color? It would be probably better to leave the background in fuchsia and the text color in white, so it improves the contrast and we don't need so lighter colors for hovering/clicking. Something closer to the Toggle Dark button, but following your design.

I want our CTA button to match our mascot's main color, so that's why I'm using Fuchsia as text color. The idea is that our site "feels" fuchsia, because that's the octopus main body color. 😉

I don't like having white text on a colored background, it looks ugly, and it has less contrast than having a dark colored text on a light background.

@Belco90
Copy link
Member Author

Belco90 commented Oct 21, 2021

I want our CTA button to match our mascot's main color, so that's why I'm using Fuchsia as text color. The idea is that our site "feels" fuchsia, because that's the octopus main body color. 😉

I don't like having white text on a colored background, it looks ugly, and it has less contrast than having a dark colored text on a light background.

Fair enough! I've checked your changes, it looks better. I'll apply the shadow improvements later.

@Belco90 Belco90 marked this pull request as ready for review October 21, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make call to action button component
2 participants